Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#175535051] fixes offset scroller for messages (iphone 7) #2791

Merged
merged 12 commits into from
Mar 31, 2021

Conversation

qesya
Copy link
Contributor

@qesya qesya commented Feb 6, 2021

Short description

fixes offset for messages

Screenshot 2021-02-06 at 20 58 09

@qesya qesya changed the title fix:[#175535051 fixes offset scroller for messages (iphone 7) fix:[#175535051] fixes offset scroller for messages (iphone 7) Feb 6, 2021
@pagopa-github-bot pagopa-github-bot changed the title fix:[#175535051] fixes offset scroller for messages (iphone 7) fix: fix:[#175535051] fixes offset scroller for messages (iphone 7) Feb 6, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Feb 6, 2021

Affected stories

  • 🐞 #175535051: Scroll dettaglio messaggio con offset errato (iPhone 7)

Generated by 🚫 dangerJS against 0f7d43d

@qesya qesya changed the title fix: fix:[#175535051] fixes offset scroller for messages (iphone 7) fix: [#175535051] fixes offset scroller for messages (iphone 7) Feb 6, 2021
@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #2791 (0f7d43d) into master (2ad3755) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2791   +/-   ##
=======================================
  Coverage   58.50%   58.50%           
=======================================
  Files         902      902           
  Lines       24754    24759    +5     
  Branches     4556     4559    +3     
=======================================
+ Hits        14482    14485    +3     
- Misses      10179    10181    +2     
  Partials       93       93           
Impacted Files Coverage Δ
ts/components/messages/MessageDetailComponent.tsx 31.66% <33.33%> (+0.08%) ⬆️
ts/components/messages/MessageDetailCTABar.tsx 31.03% <100.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad3755...0f7d43d. Read the comment docs.

@qesya qesya self-assigned this Feb 11, 2021
@qesya qesya force-pushed the 175535051-scroll-wrong-offset branch from 0e30bfb to c32cea7 Compare February 11, 2021 16:20
@qesya qesya requested a review from debiff February 17, 2021 14:39
@debiff debiff merged commit 8c69b54 into master Mar 31, 2021
@debiff debiff deleted the 175535051-scroll-wrong-offset branch March 31, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants