Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#176476117] Improved localization of TouchID dialog on Android #2788

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

DavideValdo
Copy link
Contributor

@DavideValdo DavideValdo commented Feb 5, 2021

Short description

On Android, upon fingerprint identification failure, a properly localized label is now shown instead of "Failed" no matter the locale.

The label below that, instead, remains "Not recognized. Try again" despite the locale being set to Italian. After multiple failed attemps, instead, the label changes according to the system locale "Troppi tentativi. Riprova più tardi".

For iOS behavior see story discussion on Pivotal.

List of changes proposed in this pull request

  • See the label aside the fingerprint (Italian):

localized-label-touchid-fail

How to test

  • Run the app on Android with device/simulator supporting fingerprint recognition
  • Trigger a non-matching response

@pagopa-github-bot pagopa-github-bot changed the title [#176476117] Improved localization of TouchID dialog on Android fix: [#176476117] Improved localization of TouchID dialog on Android Feb 5, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Feb 5, 2021

Affected stories

  • 🐞 #176476117: [minor] in caso di fallimento nell'autenticazione biometrica il messaggio di errore non è localizzato

Generated by 🚫 dangerJS against da782d3

Copy link
Contributor

@thisisjp thisisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy looks good to me, thanks

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #2788 (da782d3) into master (8526cb8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2788   +/-   ##
=======================================
  Coverage   53.95%   53.95%           
=======================================
  Files         804      804           
  Lines       22248    22248           
  Branches     4187     4187           
=======================================
  Hits        12004    12004           
  Misses      10188    10188           
  Partials       56       56           
Impacted Files Coverage Δ
ts/utils/biometric.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8526cb8...da782d3. Read the comment docs.

@pagopa-github-bot pagopa-github-bot changed the title fix: [#176476117] Improved localization of TouchID dialog on Android fix: [#176476117] Improved localization of TouchID dialog on Android Feb 8, 2021
@Undermaken Undermaken merged commit f4b64ca into master Feb 8, 2021
@fabriziofff fabriziofff deleted the 176476117-improve-touch-id-localization branch January 21, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants