chore: [#176778467] Track loading services details stats #2785
Conversation
Undermaken
changed the title
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2785 +/- ##
==========================================
- Coverage 54.03% 53.98% -0.06%
==========================================
Files 804 804
Lines 22203 22234 +31
Branches 4170 4180 +10
==========================================
+ Hits 11997 12002 +5
- Misses 10150 10176 +26
Partials 56 56
Continue to review full report at Codecov.
|
Undermaken
requested review from
CrisTofani,
debiff and
fabriziofff
as code owners
There was a problem hiding this comment.
@Undermaken could you add SERVICES_DETAIL_LOADING_STATS to the mixpanel list with the possible payload parameters?
|
@fabriziofff |
| startTime: new Date().getTime() as Millisecond, | ||
| servicesId: new Set([...action.payload]), | ||
| loaded: 0, | ||
| toLoad: servicesDetailLoadTrack.servicesId.size |
There was a problem hiding this comment.
| toLoad: servicesDetailLoadTrack.servicesId.size | |
| toLoad: action.payload.length |
With the current implementation toLoad is always 0.
There was a problem hiding this comment.
that's a bug, due to refactoring!
Good catch!
fixed
29baf38
| trackServicesDetailLoad({ | ||
| ...servicesDetailLoadTrack, | ||
| kind: "COMPLETE", | ||
| loadingTime: (new Date().getTime() - | ||
| servicesDetailLoadTrack.startTime) as Millisecond | ||
| }); |
There was a problem hiding this comment.
With some multiple tries on Android, I ran into this case (kind
PARTIAL):
My proposal:
create a common function to calculate the loading time
const calculateLoadingTime = (startTime: Millisecond): Millisecond =>
(startTime !== 0 ? new Date().getTime() - startTime : 0) as Millisecond;and use it at line 147 and 163.
There was a problem hiding this comment.
Maybe this scenario is when the app changes state but actually it is not loading any service
I add your suggestion and a condition to send "PARTIAL" only when there is a services loading running
Short description
This PR is useful to keep track of some measurements about loading services details
It is strictly related to this workaround about services loading
This tracking is based on a "in memory" stats tracking: the usage of the store (actions + reducer) adds a certain overhead and needs extra code to cover all cases