Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#176576695,#176578086,#176578131] Added search co-badge ko screens #2774

Merged
merged 63 commits into from
Feb 10, 2021

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Feb 3, 2021

This pr depends on #2768

Short description

This pr adds all the ko screens for the search co-badge sub-phase.

CoBadgeKoNotFound CoBadgeKoServiceError CoBadgeKoSingleBankNotFound
CoBadgeKoTimeout LoadCoBadgeSearch

List of changes proposed in this pull request

  • Graphical update for CoBadgeKoNotFound, CoBadgeKoServiceError, CoBadgeKoSingleBankNotFound, CoBadgeKoTimeout and LoadCoBadgeSearch.

@pagopa-github-bot pagopa-github-bot changed the title [#176245381] Added search co-badge ko screens feat(Bonus Pagamenti Digitali): [#176245381] Added search co-badge ko screens Feb 3, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Feb 3, 2021

Affected stories

  • 🌟 #176576695: Come CIT, quando ricerco le carte di circuito internazionale a partire dal mio BANCOMAT e trascorre il massimo timeout o ricevo una risposta parziale, voglio visualizzare una schermata che mi avvisa che al momento non è possibile ricercare le mie carte
  • 🌟 #176578086: Come CIT, quando ricerco le carte di circuito internazionale a partire dal mio BANCOMAT e non vengono trovate carte, voglio visualizzare una schermata che mi invita a cercare tra tutte le banche
  • 🌟 #176578131: Come CIT, quando ricerco le carte di circuito internazionale tra tutte le banche e non vengono trovate carte, voglio visualizzare una schermata che mi avvisa

Generated by 🚫 dangerJS against acbfabe

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #2774 (acbfabe) into master (048b0e2) will decrease coverage by 0.01%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2774      +/-   ##
==========================================
- Coverage   54.86%   54.84%   -0.02%     
==========================================
  Files         813      813              
  Lines       22515    22541      +26     
  Branches     4232     4232              
==========================================
+ Hits        12352    12363      +11     
- Misses      10102    10117      +15     
  Partials       61       61              
Impacted Files Coverage Δ
...ge/screens/search/SearchAvailableCoBadgeScreen.tsx 46.29% <ø> (ø)
...ing/cobadge/screens/start/LoadAbiConfiguration.tsx 63.15% <ø> (ø)
...obadge/screens/start/ko/CoBadgeStartKoDisabled.tsx 72.72% <0.00%> (-4.70%) ⬇️
...dge/screens/start/ko/CoBadgeStartKoUnavailable.tsx 76.92% <0.00%> (-6.42%) ⬇️
...ing/cobadge/screens/search/ko/CoBadgeKoTimeout.tsx 71.42% <25.00%> (-4.58%) ⬇️
.../screens/search/ko/CoBadgeKoSingleBankNotFound.tsx 70.00% <33.33%> (-4.08%) ⬇️
...obadge/screens/search/ko/CoBadgeKoServiceError.tsx 76.92% <42.85%> (-4.90%) ⬇️
...ng/cobadge/screens/search/ko/CoBadgeKoNotFound.tsx 72.72% <53.33%> (-9.10%) ⬇️
...rding/cobadge/screens/search/LoadCoBadgeSearch.tsx 60.00% <100.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048b0e2...acbfabe. Read the comment docs.

@fabriziofff fabriziofff changed the title feat(Bonus Pagamenti Digitali): [#176245381] Added search co-badge ko screens feat(Bonus Pagamenti Digitali): [#176576695,#176578086,#176578131] Added search co-badge ko screens Feb 3, 2021
@fabriziofff fabriziofff changed the title feat(Bonus Pagamenti Digitali): [#176576695,#176578086,#176578131] Added search co-badge ko screens feat(Bonus Pagamenti Digitali): [#176576695,#176578086,#176578131,#176578131] Added search co-badge ko screens Feb 3, 2021
@fabriziofff fabriziofff changed the title feat(Bonus Pagamenti Digitali): [#176576695,#176578086,#176578131,#176578131] Added search co-badge ko screens feat(Bonus Pagamenti Digitali): [#176576695,#176578086,#176578131] Added search co-badge ko screens Feb 3, 2021
fabriziofff and others added 17 commits February 4, 2021 20:10
Co-authored-by: Jacopo Pompilii <[email protected]>
Co-authored-by: Jacopo Pompilii <[email protected]>
Co-authored-by: Jacopo Pompilii <[email protected]>
Co-authored-by: Jacopo Pompilii <[email protected]>
Co-authored-by: Jacopo Pompilii <[email protected]>
locales/it/index.yml Show resolved Hide resolved
@Undermaken Undermaken merged commit b455e36 into master Feb 10, 2021
@fabriziofff fabriziofff deleted the 176245381-ko-search-cobadge-screens branch January 21, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants