feat(Bonus Pagamenti Digitali): [#176738620] Choose card type before starting the co-badge onboarding workflow #2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd-type' into 176738620-choose-card-type
fabriziofff
requested review from
CrisTofani,
debiff and
Undermaken
as code owners
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2766 +/- ##
==========================================
+ Coverage 53.99% 54.02% +0.03%
==========================================
Files 802 804 +2
Lines 22136 22192 +56
Branches 4169 4166 -3
==========================================
+ Hits 11952 11990 +38
- Misses 10128 10146 +18
Partials 56 56
Continue to review full report at Codecov.
|
debiff
approved these changes
Feb 3, 2021
| @@ -30,10 +32,12 @@ const loadLocales = () => ({ | |||
| */ | |||
| const CoBadgeKoServiceError: React.FunctionComponent<Props> = props => { | |||
| const { headerTitle, title, body } = loadLocales(); | |||
|
|
|||
| // disable hardware back | |||
| useHardwareBackButton(() => true); | |||
There was a problem hiding this comment.
why this is needed? Can you leave also a comment about this?
There was a problem hiding this comment.
ts/features/wallet/onboarding/cobadge/screens/search/ko/CoBadgeKoTimeout.tsx
Show resolved
Hide resolved
ts/features/wallet/onboarding/cobadge/screens/search/ko/CoBadgeKoSingleBankNotFound.tsx
Show resolved
Hide resolved
| @@ -29,10 +31,12 @@ const loadLocales = () => ({ | |||
| */ | |||
| const CoBadgeKoNotFound = (props: Props): React.ReactElement => { | |||
| const { headerTitle, title, body } = loadLocales(); | |||
|
|
|||
| // disable hardware back | |||
There was a problem hiding this comment.
Same as CoBadgeKoServiceError.tsx
Undermaken
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pr allows the user to choose the type of card to add, before starting the co-badge card addition flow.
Registrazione.schermo.2021-02-02.alle.10.56.07.mov
List of changes proposed in this pull request
navigateToOnboardingCoBadgeChooseTypeStartScreenin order to acceptsCoBadgeChooseTypeNavigationPropsas paramsCoBadgeChooseTypescreen, that allows the user to choose the right workflowwalletAddCoBadgeFromBancomatStartand changedwalletAddCoBadgeStartin order to accept a single abi as param.