feat(Bonus Pagamenti Digitali): [#176455937] Error and loading screen transaction details #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debiff
requested review from
CrisTofani,
fabriziofff and
Undermaken
as code owners
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2755 +/- ##
==========================================
+ Coverage 54.37% 54.97% +0.60%
==========================================
Files 809 812 +3
Lines 22381 22438 +57
Branches 4199 4202 +3
==========================================
+ Hits 12169 12335 +166
+ Misses 10153 10042 -111
- Partials 59 61 +2
Continue to review full report at Codecov.
|
CrisTofani
requested changes
Feb 1, 2021
| completeUnsubscription: () => { | ||
| dispatch(bpdAllData.request()); | ||
| dispatch(bpdUnsubscribeCompleted()); | ||
| dispatch(NavigationActions.back()); | ||
| }, | ||
| goToTransactions: () => dispatch(navigateToBpdTransactions()), | ||
| goToTransactions: () => { |
There was a problem hiding this comment.
Is this needed? It looks the same or did you forgot to add another dispatch call?
There was a problem hiding this comment.
No, I added and removed another dispatch but I forgot to remove the brackets, fixed in 01eb23e
fabriziofff
suggested changes
Feb 9, 2021
Comment on lines
107
to
113
| <GoToTransactions | ||
| goToTransactions={() => | ||
| // if the transactions state is in pot.isError state | ||
| // on press request a refresh | ||
| props.goToTransactions() | ||
| } | ||
| /> |
There was a problem hiding this comment.
Suggested change
| <GoToTransactions | |
| goToTransactions={() => | |
| // if the transactions state is in pot.isError state | |
| // on press request a refresh | |
| props.goToTransactions() | |
| } | |
| /> | |
| <GoToTransactions goToTransactions={props.goToTransactions} /> |
It seems to me that the comment refers to a piece of code that is no longer present.
There was a problem hiding this comment.
You're right! Fixed in f05e33e
| }); | ||
|
|
||
| /** | ||
| * This screen informs the user that there are problem in retrieve the transactions list. |
There was a problem hiding this comment.
Suggested change
| * This screen informs the user that there are problem in retrieve the transactions list. | |
| * This screen informs the user that there are problems retrieving the transactions list. |
…een-transaction-details' into 176455937-error-screen-transaction-details
fabriziofff
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR add the loading and the error screen in the section "transaction details" of a bpd period detail.
List of changes proposed in this pull request
Available transaction
Loading transaction
Unavailable transaction