feat(Bonus Pagamenti Digitali): [#176575256,#176578559,#176578568] Co-badge card onboarding workflow #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…650-action-store-reducers
…662-navigation-screen-stubs
pagopa-github-bot
changed the title
Affected stories
Error TypeErrorDangerfile |
Codecov Report
@@ Coverage Diff @@
## master #2752 +/- ##
==========================================
+ Coverage 53.84% 53.91% +0.06%
==========================================
Files 782 792 +10
Lines 21591 21873 +282
Branches 4092 3778 -314
==========================================
+ Hits 11625 11792 +167
- Misses 9910 10025 +115
Partials 56 56
Continue to review full report at Codecov.
|
move cobadge models to cobadge/configuration
…662-navigation-screen-stubs
fabriziofff
requested review from
CrisTofani,
debiff and
Undermaken
as code owners
…256-onboarding-cobadge
…76559662-navigation-screen-stubs
Undermaken
approved these changes
Jan 29, 2021
ts/features/wallet/onboarding/cobadge/saga/orchestration/addCoBadgeToWallet.ts
Outdated
Show resolved
Hide resolved
ts/features/wallet/onboarding/cobadge/saga/orchestration/addCoBadgeToWallet.ts
Outdated
Show resolved
Hide resolved
ts/features/wallet/onboarding/cobadge/saga/orchestration/addCoBadgeToWallet.ts
Outdated
Show resolved
Hide resolved
ts/features/wallet/onboarding/cobadge/saga/orchestration/addCoBadgeToWallet.ts
Outdated
Show resolved
Hide resolved
…g-cobadge' into 176575256-onboarding-cobadge
debiff
approved these changes
Jan 29, 2021
| if (bancomat.abiInfo?.abi) { | ||
| props.addCoBadge(bancomat.abiInfo.abi); | ||
| } else { | ||
| showToast(I18n.t("global.genericError"), "danger"); |
There was a problem hiding this comment.
Can't we return a more specific message in this case?
| @@ -16,9 +16,10 @@ const abiSelectedReducer = ( | |||
| switch (action.type) { | |||
| case getType(searchUserCoBadge.request): | |||
| return action.payload ?? null; | |||
There was a problem hiding this comment.
Suggested change
| return action.payload ?? null; | |
| case getType(walletAddCoBadgeFromBancomatStart): | |
| return action.payload ?? null; |
fabriziofff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr depends on #2750
Short description
This pr implements the "add co-badge to wallet" workflow, starting from a BANCOMAT.
Registrazione.schermo.2021-01-28.alle.21.59.51.mov
List of changes proposed in this pull request
BancomatDetailScreenin order to handle the new workflow (instead of the static handling inside theBancomatInformationcomponent)ts/features/wallet/onboarding/bancomat/store/reducers/addingPans.tswith the actionwalletAddBancomatStartts/features/wallet/onboarding/bancomatPay/store/reducers/addingBPay.tswith the actionwalletAddBPayStartCoBadgeStartScreents/features/wallet/onboarding/cobadge/saga/orchestration/addCoBadgeToWallet.tsto orchestrate the workflowts/features/wallet/onboarding/cobadge/screens/search/SearchAvailableCoBadgeScreen.tsxin order to handling the results of the search available co-badge cardsts/features/wallet/onboarding/cobadge/screens/start/CoBadgeStartScreen.tsxin order to handling the abi configuration loading.ts/features/wallet/onboarding/cobadge/store/reducers/abiConfiguration.tsstore & reducerHow to test
Manual test from entry point: