Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#176559662] Navigation & screen stubs for co-badge workflow #2750

Merged
merged 9 commits into from
Jan 27, 2021

Conversation

fabriziofff
Copy link
Contributor

Short description

This pr adds the skeleton for all the screens required in the co-badge workflow & configures the navigation.

List of changes proposed in this pull request

  • Add some placeholder for the locales
  • Add Actions, navigator and routes
  • Add screens placeholder

@pagopa-github-bot pagopa-github-bot changed the title [#176559662] Navigation & screen stubs for co-badge workflow feat(Bonus Pagamenti Digitali): [#176559662] Navigation & screen stubs for co-badge workflow Jan 25, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 25, 2021

Affected stories

  • 🌟 #176559662: Ci occorrono stub degli screen e di navigazione per il flusso di onboading co-badge

Generated by 🚫 dangerJS against d0c67a7

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #2750 (d0c67a7) into master (4e4e1b6) will increase coverage by 0.08%.
The diff coverage is 65.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2750      +/-   ##
==========================================
+ Coverage   53.59%   53.68%   +0.08%     
==========================================
  Files         770      780      +10     
  Lines       21362    21530     +168     
  Branches     4063     4078      +15     
==========================================
+ Hits        11449    11558     +109     
- Misses       9858     9917      +59     
  Partials       55       55              
Impacted Files Coverage Δ
...g/cobadge/screens/add-account/AddCoBadgeScreen.tsx 38.29% <38.29%> (ø)
...ge/screens/add-account/LoadAddCoBadgeComponent.tsx 50.00% <50.00%> (ø)
...rding/cobadge/screens/search/LoadCoBadgeSearch.tsx 57.89% <57.89%> (ø)
...ge/screens/search/SearchAvailableCoBadgeScreen.tsx 60.86% <60.86%> (ø)
...ing/cobadge/screens/search/ko/CoBadgeKoTimeout.tsx 77.27% <77.27%> (ø)
...ng/cobadge/screens/search/ko/CoBadgeKoNotFound.tsx 84.21% <84.21%> (ø)
.../wallet/onboarding/cobadge/navigation/navigator.ts 100.00% <100.00%> (ø)
...res/wallet/onboarding/cobadge/navigation/routes.ts 100.00% <100.00%> (ø)
.../cobadge/screens/ActivateBpdOnNewCoBadgeScreen.tsx 100.00% <100.00%> (ø)
...dge/screens/start/CoBadgeStartSingleBankScreen.tsx 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4e1b6...d0c67a7. Read the comment docs.

@@ -37,7 +37,7 @@ const foundCoBadgeReducer = (
* Remove from the list the disabled accounts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment right? Can't understand where are filtered the disabled accounts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! Removed in d0c67a7

@fabriziofff fabriziofff requested a review from debiff January 27, 2021 15:40
@debiff debiff merged commit 4c2654f into master Jan 27, 2021
@debiff debiff deleted the 176559662-navigation-screen-stubs branch January 27, 2021 15:49
@Undermaken Undermaken restored the 176559662-navigation-screen-stubs branch January 29, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants