fix(Bonus Pagamenti Digitali): [#176477833] Fixed mistake that inhibited BPD CTA to properly show #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideValdo
requested review from
CrisTofani,
fabriziofff and
Undermaken
as code owners
pagopa-github-bot
changed the title
Affected stories
|
pagopa-github-bot
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2738 +/- ##
=======================================
Coverage 53.68% 53.68%
=======================================
Files 780 780
Lines 21530 21530
Branches 4078 4078
=======================================
Hits 11558 11558
Misses 9917 9917
Partials 55 55
Continue to review full report at Codecov.
|
pagopa-github-bot
changed the title
pagopa-github-bot
changed the title
pagopa-github-bot
changed the title
CrisTofani
requested changes
Jan 28, 2021
| const [CTAVisibility, setCTAVisibility] = React.useState(false); | ||
|
|
||
| const setCTAVisible = () => setCTAVisibility(true); | ||
| const setCTAVisible = () => | ||
| setTimeout(() => setCTAVisibility(true), SHOW_CTA_DELAY); |
There was a problem hiding this comment.
Suggested change
| setTimeout(() => setCTAVisibility(true), SHOW_CTA_DELAY); | |
| setCTAVisibility(true); |
We can avoid the usage of a setTimeout here, I tested the solution with the direct call of a setState and it actually works
There was a problem hiding this comment.
@thisisjp If we remove setTimeout the CTA will actually be visible a fraction of a second before the content appears, but we get better code readibility, is this ok with you?
There was a problem hiding this comment.
no problem at all, thanks ;)
pagopa-github-bot
changed the title
CrisTofani
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This was tricky, apparently we need to use JSX to make hooks work.
How to test
Registrazione.schermo.2021-01-19.alle.19.20.59.mov