Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop react-native-qrcode-scanner patch #2735

Merged
merged 3 commits into from
Mar 1, 2021

Conversation

bfabio
Copy link
Contributor

@bfabio bfabio commented Jan 16, 2021

The original patch was merged by #1824.

The patch is not longer needed as it was upstreamed by
moaazsidat/react-native-qrcode-scanner#280
and released in 1.5.1

Note that I didn't actually test this as I don't have the development environment handy right now.

@Undermaken
Copy link
Contributor

@bfabio thanks for your contribution
So, beyond your change, can the packages.json targets the version ^1.5.3 of react-native-qrcode-scanner?

@bfabio
Copy link
Contributor Author

bfabio commented Jan 23, 2021

@Undermaken Sure, done.

@Undermaken
Copy link
Contributor

@bfabio I tested this PR and it looks good!

Last missing step:
the updated yarn.lock file: run yarn install and then push the changes

@bfabio
Copy link
Contributor Author

bfabio commented Feb 27, 2021

@Undermaken done, sorry for the long delay, but these are busy days ;)

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #2735 (8c87d93) into master (406cb03) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2735   +/-   ##
=======================================
  Coverage   57.21%   57.21%           
=======================================
  Files         827      827           
  Lines       22997    22997           
  Branches     4308     4308           
=======================================
  Hits        13157    13157           
  Misses       9752     9752           
  Partials       88       88           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 406cb03...8c87d93. Read the comment docs.

@Undermaken
Copy link
Contributor

@Undermaken done, sorry for the long delay, but these are busy days ;)

we have no deadlines for spontaneous support ;)
thanks again

@Undermaken Undermaken merged commit 8b59304 into pagopa:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants