-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop react-native-qrcode-scanner patch #2735
Conversation
@bfabio thanks for your contribution |
@Undermaken Sure, done. |
@bfabio I tested this PR and it looks good! Last missing step: |
The patch is not longer needed as it was upstreamed by moaazsidat/react-native-qrcode-scanner#280 and released in 1.5.1
@Undermaken done, sorry for the long delay, but these are busy days ;) |
Codecov Report
@@ Coverage Diff @@
## master #2735 +/- ##
=======================================
Coverage 57.21% 57.21%
=======================================
Files 827 827
Lines 22997 22997
Branches 4308 4308
=======================================
Hits 13157 13157
Misses 9752 9752
Partials 88 88 Continue to review full report at Codecov.
|
we have no deadlines for spontaneous support ;) |
The original patch was merged by #1824.
The patch is not longer needed as it was upstreamed by
moaazsidat/react-native-qrcode-scanner#280
and released in 1.5.1
Note that I didn't actually test this as I don't have the development environment handy right now.