-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Carta Giovani Nazionale): [#176443163] New bonuses available visibility and start cgn flow logic #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matteo Boschi <[email protected]>
Co-authored-by: Matteo Boschi <[email protected]>
Co-authored-by: fabriziofff <[email protected]>
Co-authored-by: fabriziofff <[email protected]>
Co-authored-by: fabriziofff <[email protected]>
Co-authored-by: fabriziofff <[email protected]>
pagopa-github-bot
changed the title
[#176443163] New bonuses available visibility and start cgn flow logic
feat(Carta Giovani Nazionale): [#176443163] New bonuses available visibility and start cgn flow logic
Jan 15, 2021
Affected stories
|
…76443044-store-directories-skeleton-cgn
…of github.com:pagopa/io-app into 176443163-handle-cgn-bonus-information
Codecov Report
@@ Coverage Diff @@
## master #2733 +/- ##
==========================================
+ Coverage 53.53% 53.59% +0.06%
==========================================
Files 767 770 +3
Lines 21325 21362 +37
Branches 3726 4063 +337
==========================================
+ Hits 11416 11449 +33
- Misses 9854 9858 +4
Partials 55 55
Continue to review full report at Codecov.
|
…76443044-store-directories-skeleton-cgn
…of github.com:pagopa/io-app into 176443163-handle-cgn-bonus-information
Undermaken
suggested changes
Jan 25, 2021
ts/features/bonus/bonusVacanze/store/reducers/availableBonusesTypes.ts
Outdated
Show resolved
Hide resolved
ts/features/bonus/bpd/saga/orchestration/onboarding/startOnboarding.ts
Outdated
Show resolved
Hide resolved
ts/features/bonus/bonusVacanze/store/reducers/__tests__/availableBonusesTypes.test.ts
Show resolved
Hide resolved
…Types.ts Co-authored-by: Matteo Boschi <[email protected]>
Co-authored-by: Matteo Boschi <[email protected]>
Undermaken
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR IS BASED ON #2718
Short description
This PR introduces a new visibility handler logic for bonuses and adds the base saga logic to begin the cgn request flow.
List of changes proposed in this pull request
How to test
Generate Content specs based on this file and use
io-dev-server
withsupport-cgn
branchBefore merging this PR, the merge of the PR on io-dev-server is needed