Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Carta Giovani Nazionale): [#176443163] New bonuses available visibility and start cgn flow logic #2733

Merged
merged 34 commits into from
Jan 25, 2021

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Jan 15, 2021

THIS PR IS BASED ON #2718

Short description

This PR introduces a new visibility handler logic for bonuses and adds the base saga logic to begin the cgn request flow.

List of changes proposed in this pull request

  • Removes the locale fallback for bonuses available
  • Removes the API call to previous version fo the file
  • Implements base saga logic for the activation flow.

How to test

Generate Content specs based on this file and use io-dev-server with support-cgn branch

Before merging this PR, the merge of the PR on io-dev-server is needed

@pagopa-github-bot pagopa-github-bot changed the title [#176443163] New bonuses available visibility and start cgn flow logic feat(Carta Giovani Nazionale): [#176443163] New bonuses available visibility and start cgn flow logic Jan 15, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 15, 2021

Affected stories

  • 🌟 #176443163: Come GIOVANE voglio consultare il dettaglio della iniziativa prima di richiedere una CGN

Generated by 🚫 dangerJS against ce99b47

@CrisTofani CrisTofani marked this pull request as ready for review January 18, 2021 10:36
…of github.com:pagopa/io-app into 176443163-handle-cgn-bonus-information
@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #2733 (ce99b47) into master (6c3e30b) will increase coverage by 0.06%.
The diff coverage is 73.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2733      +/-   ##
==========================================
+ Coverage   53.53%   53.59%   +0.06%     
==========================================
  Files         767      770       +3     
  Lines       21325    21362      +37     
  Branches     3726     4063     +337     
==========================================
+ Hits        11416    11449      +33     
- Misses       9854     9858       +4     
  Partials       55       55              
Impacted Files Coverage Δ
...s/features/bonus/bonusVacanze/__mock__/mockData.ts 100.00% <ø> (ø)
ts/api/content.ts 44.44% <50.00%> (+2.33%) ⬆️
...onus/bonusVacanze/screens/AvailableBonusScreen.tsx 45.83% <50.00%> (ø)
...us/cgn/screens/onboarding/CgnInformationScreen.tsx 66.66% <50.00%> (ø)
ts/sagas/startup.ts 53.89% <50.00%> (-0.06%) ⬇️
...atures/bonus/cgn/saga/activation/activationSaga.ts 58.33% <58.33%> (ø)
ts/features/bonus/cgn/saga/index.ts 83.33% <83.33%> (ø)
...nusVacanze/store/reducers/availableBonusesTypes.ts 72.50% <92.85%> (+12.50%) ⬆️
...es/bonus/bonusVacanze/__mock__/availableBonuses.ts 100.00% <100.00%> (ø)
ts/features/bonus/cgn/store/actions/activation.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c3e30b...ce99b47. Read the comment docs.

…of github.com:pagopa/io-app into 176443163-handle-cgn-bonus-information
@CrisTofani CrisTofani requested a review from debiff as a code owner January 25, 2021 10:38
@CrisTofani CrisTofani requested a review from Undermaken January 25, 2021 14:57
@Undermaken Undermaken merged commit 4e4e1b6 into master Jan 25, 2021
@CrisTofani CrisTofani deleted the 176443163-handle-cgn-bonus-information branch January 29, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants