Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Payments): [#176409411] Update message detail info #2729

Merged
merged 9 commits into from
Jan 19, 2021

Conversation

debiff
Copy link
Contributor

@debiff debiff commented Jan 15, 2021

Short description

This PR update the text and the colours of the dueDateBar and the CTA message, in the message detail.
Also align the calendar colours in the message list.

List of changes proposed in this pull request

  • Updated the message details as follow:

Valid Message

Expiring Message

Expired Message

  • Updated the calendar colour in message list as follow (modified only expiring color):

@pagopa-github-bot pagopa-github-bot changed the title [#176409411] Update message detail info feat(Payments): [#176409411] Update message detail info Jan 15, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 15, 2021

Affected stories

  • 🌟 #176409411: Come CIT voglio vedere, nel dettaglio di un messaggio, informazioni aggiornate sullo stato di un pagamento

Generated by 🚫 dangerJS against 088e9c4

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #2729 (088e9c4) into master (5bc6f7b) will increase coverage by 0.03%.
The diff coverage is 5.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2729      +/-   ##
==========================================
+ Coverage   53.18%   53.22%   +0.03%     
==========================================
  Files         758      758              
  Lines       21233    21210      -23     
  Branches     4031     4018      -13     
==========================================
- Hits        11293    11289       -4     
+ Misses       9886     9867      -19     
  Partials       54       54              
Impacted Files Coverage Δ
ts/components/messages/MessageListCTABar.tsx 28.57% <ø> (+0.79%) ⬆️
ts/components/messages/PaymentButton.tsx 30.64% <0.00%> (+1.85%) ⬆️
ts/components/messages/MessageDueDateBar.tsx 37.66% <6.25%> (+2.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc6f7b...088e9c4. Read the comment docs.

@Undermaken
Copy link
Contributor

Undermaken commented Jan 19, 2021

@debiff I just pushed a commit
It should be a fix:
if we considering a message expired or expiring before paid we could show a wrong information. Check it out these screens about a message that is expired (without invalid after due date) and paid

before with last commit
before with last commit

Could you check if this commit makes sense?

@debiff
Copy link
Contributor Author

debiff commented Jan 19, 2021

Could you check if this commit makes sense?

@Undermaken yes you're right. Thank you

@Undermaken Undermaken merged commit b9faf1a into master Jan 19, 2021
@Undermaken Undermaken deleted the 176409411-update-message-detail-info branch January 19, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants