Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#176484406] Remove first place from supercashback ranking #2725

Merged
merged 6 commits into from
Jan 15, 2021

Conversation

fabriziofff
Copy link
Contributor

Short description

This pr removes the first place from the supercashback ranking details.

position === 1st position 1<position<last_position
position === last_position position > last_position

List of changes proposed in this pull request

  • Remove FirstPositionItem component.
  • Remove FirstPositionItem entry fromSuperCashbackRanking.tsx

How to test

Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

@pagopa-github-bot pagopa-github-bot changed the title [#176484406] Remove first place from supercashback ranking feat(Bonus Pagamenti Digitali): [#176484406] Remove first place from supercashback ranking Jan 14, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 14, 2021

Affected stories

  • 🌟 #176484406: Come CIT voglio vedere la mia posizione in classifica, rispetto a quella dell 100.000° utente

Generated by 🚫 dangerJS against fab20cd

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #2725 (fab20cd) into master (ff638a4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2725      +/-   ##
==========================================
- Coverage   51.75%   51.74%   -0.02%     
==========================================
  Files         751      750       -1     
  Lines       21114    21109       -5     
  Branches     4020     3693     -327     
==========================================
- Hits        10928    10923       -5     
  Misses      10144    10144              
  Partials       42       42              
Impacted Files Coverage Δ
...ents/superCashbackRanking/SuperCashbackRanking.tsx 65.00% <100.00%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff638a4...fab20cd. Read the comment docs.

@Undermaken Undermaken merged commit 6067156 into master Jan 15, 2021
@Undermaken Undermaken deleted the 176484406-remove-first-bpd-ranking branch January 15, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants