Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#176457237] Remove disabled account from BPay found list #2720

Merged
merged 5 commits into from
Jan 14, 2021

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Jan 13, 2021

Short description

This pr removes the BPay account found with serviceState=== DIS from the list of the found BPay account.
An user cannot see a disabled account in their list.

List of changes proposed in this pull request

  • Changed onboardingBPayFoundAccountsSelector in order to filter the serviceState!== DIS accounts.

How to test

  • run ts/features/wallet/onboarding/bancomatPay/store/reducers/__test__/foundBpay.test.ts

@pagopa-github-bot pagopa-github-bot changed the title [#176457237] Remove disabled account from BPay list feat(Bonus Pagamenti Digitali): [#176457237] Remove disabled account from BPay list Jan 13, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 13, 2021

Affected stories

  • 🌟 #176457237: Come CIT, quando aggiungo i miei BPay al wallet, non voglio visualizzare i miei account BPay disattivati

Generated by 🚫 dangerJS against 41e5ae1

@fabriziofff fabriziofff marked this pull request as ready for review January 13, 2021 17:33
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #2720 (41e5ae1) into master (548ba06) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2720      +/-   ##
==========================================
+ Coverage   51.69%   51.74%   +0.04%     
==========================================
  Files         750      751       +1     
  Lines       21096    21101       +5     
  Branches     3691     3693       +2     
==========================================
+ Hits        10905    10918      +13     
+ Misses      10149    10141       -8     
  Partials       42       42              
Impacted Files Coverage Δ
...g/bancomatPay/store/reducers/__mock__/bpay.mock.ts 100.00% <100.00%> (ø)
...onboarding/bancomatPay/store/reducers/foundBpay.ts 100.00% <100.00%> (+35.29%) ⬆️
...boarding/bancomatPay/store/reducers/abiSelected.ts 78.57% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548ba06...41e5ae1. Read the comment docs.

@fabriziofff fabriziofff changed the title feat(Bonus Pagamenti Digitali): [#176457237] Remove disabled account from BPay list feat(Bonus Pagamenti Digitali): [#176457237] Remove disabled account from BPay found list Jan 13, 2021
@Undermaken Undermaken merged commit d147418 into master Jan 14, 2021
@fabriziofff fabriziofff deleted the 176457237-show-only-bpay-account-active branch January 21, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants