Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bonus Pagamenti Digitali): [#176193377] Ask to send cf only on new assistance request #2710

Merged
merged 7 commits into from
Jan 11, 2021

Conversation

debiff
Copy link
Contributor

@debiff debiff commented Jan 11, 2021

Short description

This PR fix the "Reopen a report" behaviour avoiding to request the sending of the fiscal code.

List of changes proposed in this pull request

  • Request fiscal code only for BugReporting.reportType.bug
  • Set instabug support token attribute only for BugReporting.reportType.bug
Screen.Recording.2021-01-11.at.17.12.34.mov

@pagopa-github-bot pagopa-github-bot changed the title [#176193377] Ask to send cf only on new assistance request fix(Bonus Pagamenti Digitali): [#176193377] Ask to send cf only on new assistance request Jan 11, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 11, 2021

Affected stories

  • 🐞 #176193377: [major] Quando sono loggato in IO e clicco su "riapri una segnalazione" non deve chiedere di condividere il codice fiscale

Generated by 🚫 dangerJS against 1a87567

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #2710 (1a87567) into master (4f6a802) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2710      +/-   ##
==========================================
- Coverage   51.97%   51.97%   -0.01%     
==========================================
  Files         756      756              
  Lines       21299    21302       +3     
  Branches     4044     4048       +4     
==========================================
+ Hits        11070    11071       +1     
- Misses      10185    10187       +2     
  Partials       44       44              
Impacted Files Coverage Δ
ts/components/ContextualHelpModal.tsx 27.77% <0.00%> (+0.63%) ⬆️
ts/components/screens/BaseScreenComponent.tsx 24.09% <0.00%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6a802...1a87567. Read the comment docs.

@Undermaken Undermaken merged commit fe7ba13 into master Jan 11, 2021
@Undermaken Undermaken deleted the 176193377-fix-ask-cf-on-reopen-report-ch branch January 11, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants