Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bonus Pagamenti Digitali): [#176350129] Link inside bottom sheet is not tappable #2701

Merged
merged 8 commits into from
Jan 11, 2021

Conversation

Undermaken
Copy link
Contributor

Short description

This PR fixes a known bug on Android devices where read more link is not tappable
The new design is already dealt with @thisisjp

before now
before now

@pagopa-github-bot pagopa-github-bot changed the title [#176350129] Link inside bottom sheet is not tappable fix(Bonus Pagamenti Digitali): [#176350129] Link inside bottom sheet is not tappable Jan 11, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 11, 2021

Affected stories

  • 🐞 #176350129: [major] Su Android il link nella bottom sheet non è cliccabile

Generated by 🚫 dangerJS against 6d46d6a

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #2701 (6d46d6a) into master (08c036e) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2701    +/-   ##
========================================
  Coverage   51.96%   51.97%            
========================================
  Files         756      756            
  Lines       21295    21299     +4     
  Branches     3712     4044   +332     
========================================
+ Hits        11067    11070     +3     
- Misses      10184    10185     +1     
  Partials       44       44            
Impacted Files Coverage Δ
.../bpd/components/BpdTransactionSummaryComponent.tsx 85.71% <83.33%> (-0.65%) ⬇️
...s/details/transaction/BpdEmptyTransactionsList.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c036e...6d46d6a. Read the comment docs.

@Undermaken Undermaken marked this pull request as ready for review January 11, 2021 13:27
@fabriziofff fabriziofff merged commit 726af95 into master Jan 11, 2021
@fabriziofff fabriziofff deleted the 176350129-fix-android-bottom-sheet branch January 11, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants