Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175890882] Update caption for BPay ko & loading screens #2680

Merged
merged 34 commits into from
Jan 8, 2021

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Jan 7, 2021

This pr depends on #2678

Short description

This pr adds the copy for the loading and KO screens.

BPayKoNotFound BPayKoTimeout

List of changes proposed in this pull request

  • Feature A
  • Feature B

How to test

Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

@fabriziofff fabriziofff changed the title [#175890882] Update caption for ko & loading screens [#175890882] Update caption for BPay ko & loading screens Jan 7, 2021
@pagopa-github-bot pagopa-github-bot changed the title [#175890882] Update caption for BPay ko & loading screens feat(Bonus Pagamenti Digitali): [#175890882] Update caption for BPay ko & loading screens Jan 7, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 7, 2021

Affected stories

  • 🌟 #175890882: Come CIT voglio conoscere l'esito della ricerca dei miei BPay

Generated by 🚫 dangerJS against 7d322c7

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #2680 (7d322c7) into master (44f2978) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2680    +/-   ##
========================================
  Coverage   51.77%   51.77%            
========================================
  Files         749      749            
  Lines       21072    21072            
  Branches     4014     3683   -331     
========================================
  Hits        10910    10910            
  Misses      10118    10118            
  Partials       44       44            
Impacted Files Coverage Δ
.../bancomatPay/screens/add-account/AddBPayScreen.tsx 38.29% <100.00%> (ø)
...atPay/screens/add-account/LoadAddBPayComponent.tsx 54.54% <100.00%> (ø)
.../bancomatPay/screens/searchBPay/BPayKoNotFound.tsx 85.00% <100.00%> (ø)
...g/bancomatPay/screens/searchBPay/BPayKoTimeout.tsx 77.27% <100.00%> (ø)
.../bancomatPay/screens/searchBPay/LoadBPaySearch.tsx 60.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44f2978...7d322c7. Read the comment docs.

@fabriziofff fabriziofff marked this pull request as ready for review January 7, 2021 13:55
@Undermaken Undermaken merged commit 9dc52bd into master Jan 8, 2021
@Undermaken Undermaken deleted the 175890882-update-caption-for-ko-screens branch January 8, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants