Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Payments): [#176364017] Use /v1/psps/selected instead of deprecated /v1/psps #2675

Merged
merged 3 commits into from
Jan 5, 2021

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Jan 5, 2021

Short description

This PR introduces the usage of /v1/psps/selected API in place of the deprecated one /v1/psps when the app asks for the psp during a payment flow
The behavior is pretty the same but the new one wants idWallet as required param

@pagopa-github-bot pagopa-github-bot changed the title [#176364017] Use /v1/psps/selected instead of deprecated /v1/psps feat(Payments): [#176364017] Use /v1/psps/selected instead of deprecated /v1/psps Jan 5, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 5, 2021

Affected stories

  • 🌟 #176364017: Come CIT in fase di pagamento devo richiedere il PSP che gestisce la transazione usando la API /v1/psps/selected

Generated by 🚫 dangerJS against 786d3bc

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #2675 (786d3bc) into master (5c0c90f) will decrease coverage by 0.00%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2675      +/-   ##
==========================================
- Coverage   51.54%   51.54%   -0.01%     
==========================================
  Files         730      730              
  Lines       20737    20741       +4     
  Branches     3971     3968       -3     
==========================================
+ Hits        10689    10691       +2     
- Misses      10004    10006       +2     
  Partials       44       44              
Impacted Files Coverage Δ
ts/sagas/wallet/pagopaApis.ts 18.83% <0.00%> (ø)
ts/screens/wallet/payment/common.ts 23.07% <ø> (+0.85%) ⬆️
ts/store/actions/wallet/payment.ts 100.00% <ø> (ø)
ts/api/pagopa.ts 31.00% <33.33%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c0c90f...786d3bc. Read the comment docs.

@Undermaken Undermaken marked this pull request as ready for review January 5, 2021 17:41
@fabriziofff fabriziofff merged commit a8bd66a into master Jan 5, 2021
@fabriziofff fabriziofff deleted the 176364017-psps-selected branch January 5, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants