feat: [#176299898] Amex warning (transaction >1000 EUR) #2671
Conversation
GiovanniMancini
requested review from
CrisTofani,
fabriziofff and
Undermaken
as code owners
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2671 +/- ##
========================================
Coverage 51.54% 51.54%
========================================
Files 730 730
Lines 20731 20738 +7
Branches 3967 3646 -321
========================================
+ Hits 10686 10690 +4
- Misses 10001 10004 +3
Partials 44 44
Continue to review full report at Codecov.
|
| infoBoxContainer: { padding: 20, backgroundColor: IOColors.orange }, | ||
| infoBoxMessage: { | ||
| color: IOColors.white, | ||
| backgroundColor: IOColors.orange |
There was a problem hiding this comment.
| backgroundColor: IOColors.orange |
Maybe we could avoid this background since it is already set in infoBoxContainer
There was a problem hiding this comment.
Thank you for pointing out, I'll fix it
| verifica.importoSingoloVersamento >= 100000 && ( | ||
| <View style={styles.infoBoxContainer}> | ||
| <InfoBox alignedCentral={true} iconColor={IOColors.white}> | ||
| <Text style={styles.infoBoxMessage}> |
There was a problem hiding this comment.
It's pretty the same but we should prefer IO typography components
| <Text style={styles.infoBoxMessage}> | |
| <Label weight={"Regular"} color={"white"}> | |
| {I18n.t("wallet.alert.amex")} | |
| </Label> |
| @@ -116,6 +124,16 @@ class PickPaymentMethodScreen extends React.Component<Props> { | |||
|
|
|||
| <View spacer={true} /> | |||
|
|
|||
| {wallets.some(myWallet => myWallet.creditCard?.brand === "AMEX") && | |||
| verifica.importoSingoloVersamento >= 100000 && ( | |||
There was a problem hiding this comment.
Could 10000 be a const declared outside the component?
In that way it should be easier to read/edit
https://en.wikipedia.org/wiki/Magic_number_(programming)
Short description
This PR adds an InfoBox in PickPaymentMethod Screen to warn AMEX users of limits affecting their transactions
List of changes proposed in this pull request
InfoBoxinPickPaymentMethodScreenHow to test
Visual Test: please see the attached images
Before delivery, a test in production with a real card and real payment is needed
- Test 2: No AMEX, Amount < 1000 EUR
- Test 3: Si AMEX, Amount < 1000 EUR
- Test 4: Si AMEX, Amount > 1000 EUR