Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#176191591] Open ranking details when tap on ranking preview #2652

Merged
merged 69 commits into from
Dec 29, 2020

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Dec 28, 2020

This pr depends on #2643

Short description

This pr allows to see the ranking bottomsheet details when tap on the ranking item preview.

Registrazione.schermo.2020-12-28.alle.20.38.51.mov

List of changes proposed in this pull request

  • Add tap on SuperCashbackRankingReady in order to open the bottomsheet
  • Fixed the number representation for citizens and amount in SuperCashbackBottomSheet

How to test

Tap on the preview item to open the bottomsheet

…528-supercashback-graphical-component-and-textual-summary-update
…back-graphical-component-and-textual-summary-update' into 176191528-supercashback-graphical-component-and-textual-summary-update
…back-graphical-component-and-textual-summary-update' into 176191528-supercashback-graphical-component-and-textual-summary-update
…528-supercashback-graphical-component-and-textual-summary-update
…t-and-textual-summary-update' into 176272983-ranking-not-ready
@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #2652 (1b2efe6) into master (f75a91c) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
+ Coverage   51.20%   51.29%   +0.08%     
==========================================
  Files         723      728       +5     
  Lines       20588    20673      +85     
  Branches     3640     3650      +10     
==========================================
+ Hits        10542    10604      +62     
- Misses      10002    10025      +23     
  Partials       44       44              
Impacted Files Coverage Δ
...ents/superCashbackRanking/SuperCashbackRanking.tsx 71.42% <100.00%> (ø)
...ts/summary/ranking/SuperCashbackRankingSummary.tsx 100.00% <100.00%> (ø)
...mponents/superCashbackRanking/UserPositionItem.tsx 100.00% <0.00%> (ø)
...mponents/superCashbackRanking/LastPositionItem.tsx 77.77% <0.00%> (ø)
...nents/superCashbackRanking/SuperCashbackHeader.tsx 57.69% <0.00%> (ø)
...ponents/superCashbackRanking/FirstPositionItem.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f75a91c...1b2efe6. Read the comment docs.

@fabriziofff fabriziofff marked this pull request as ready for review December 28, 2020 19:42
Copy link
Contributor

@thisisjp thisisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small proofreading :)

locales/it/index.yml Outdated Show resolved Hide resolved
locales/en/index.yml Outdated Show resolved Hide resolved
locales/en/index.yml Outdated Show resolved Hide resolved
fabriziofff and others added 10 commits December 29, 2020 12:21
Co-authored-by: Jacopo Pompilii <[email protected]>
Co-authored-by: Jacopo Pompilii <[email protected]>
Co-authored-by: Jacopo Pompilii <[email protected]>
…:pagopa/io-app into 176269197-closed-period-change-iban-cta
…f github.com:pagopa/io-app into 176269102-add-information-about-the-money-transfer-date
…76269102-add-information-about-the-money-transfer-date
…transfer-date' of github.com:pagopa/io-app into 176191591-open-ranking-details
@Undermaken Undermaken merged commit 0f75590 into master Dec 29, 2020
@Undermaken Undermaken deleted the 176191591-open-ranking-details branch December 29, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants