Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#175900141] Added profile deletion abort tracking #2649

Merged
merged 6 commits into from
Dec 31, 2020

Conversation

DavideValdo
Copy link
Contributor

Short description

MixPanel should track whenever a user aborts the account deletion process.

How to test

  • Go to Profile -> Information ... -> Delete your account
  • Follow the procedure and restart the app
  • Upon restarting, click "Cancel deletion" on the dialog
  • The event should be tracked on MixPanel

@DavideValdo DavideValdo changed the title [175900141] Added profile deletion abort tracking [#175900141] Added profile deletion abort tracking Dec 28, 2020
@DavideValdo DavideValdo requested a review from debiff December 28, 2020 14:24
@pagopa-github-bot pagopa-github-bot changed the title [#175900141] Added profile deletion abort tracking feat: [#175900141] Added profile deletion abort tracking Dec 28, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 28, 2020

Affected stories

  • 🌟 #175900141: Aggiungere eventi Abort cancellazione profilo mixpanel

Generated by 🚫 dangerJS against b3a4691

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #2649 (b3a4691) into master (305df5f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2649   +/-   ##
=======================================
  Coverage   51.49%   51.49%           
=======================================
  Files         730      730           
  Lines       20724    20724           
  Branches     3967     3967           
=======================================
  Hits        10671    10671           
  Misses      10009    10009           
  Partials       44       44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305df5f...b3a4691. Read the comment docs.

@@ -417,6 +420,7 @@ const trackAction = (mp: NonNullable<typeof mixpanel>) => (
}
break;
case getType(removeAccountMotivation):
case getType(deleteUserDataProcessing.request):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you track also the deleteUserDataProcessing.success and the deleteUserDataProcessing.failure actions?

@pagopa-github-bot pagopa-github-bot changed the title feat: [#175900141] Added profile deletion abort tracking feat: [#175900141] Added profile deletion abort tracking Dec 29, 2020
@pagopa-github-bot pagopa-github-bot changed the title feat: [#175900141] Added profile deletion abort tracking feat: [#175900141] Added profile deletion abort tracking Dec 30, 2020
@pagopa-github-bot pagopa-github-bot changed the title feat: [#175900141] Added profile deletion abort tracking feat: [#175900141] Added profile deletion abort tracking Dec 30, 2020
@pagopa-github-bot pagopa-github-bot changed the title feat: [#175900141] Added profile deletion abort tracking feat: [#175900141] Added profile deletion abort tracking Dec 30, 2020
@DavideValdo DavideValdo requested a review from debiff December 30, 2020 16:23
@pagopa-github-bot pagopa-github-bot changed the title feat: [#175900141] Added profile deletion abort tracking feat: [#175900141] Added profile deletion abort tracking Dec 30, 2020
@Undermaken Undermaken merged commit c9ecf62 into master Dec 31, 2020
@Undermaken Undermaken deleted the 175900141-track-cancel-profile-deletion branch December 31, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants