feat(Bonus Pagamenti Digitali): [#176240699,#175891337,#176166370] Convert BPD activation status to pot, prevent cashback logo flickering on Android #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2639 +/- ##
==========================================
- Coverage 51.09% 51.08% -0.02%
==========================================
Files 721 721
Lines 20537 20540 +3
Branches 3950 3632 -318
==========================================
- Hits 10493 10492 -1
- Misses 10000 10004 +4
Partials 44 44
Continue to review full report at Codecov.
|
fabriziofff
changed the title
fabriziofff
changed the title
fabriziofff
changed the title
fabriziofff
changed the title
debiff
suggested changes
Dec 28, 2020
| @@ -330,7 +325,7 @@ class WalletHomeScreen extends React.PureComponent<Props, State> { | |||
| if ( | |||
| this.props.allActiveBonus.length === 0 || | |||
| this.props.allActiveBonus.every(ab => isStrictSome(ab)) || | |||
| isReady(this.props.bpdActiveBonus) | |||
| pot.isLoading(this.props.bpdActiveBonus) | |||
There was a problem hiding this comment.
Why in this case you didn't use pot.isSome?
There was a problem hiding this comment.
I think it is a typo done during porting 😄 wrong for sure! Changed in f297755
debiff
approved these changes
Dec 28, 2020
Undermaken
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pr converts bpd activation status from
RemoteValuetopotand memoize theBpdCardsInWalletContainercomponent, in order to avoid useless rendering and prevent the cashback logo flickering on Android.List of changes proposed in this pull request
bonus/bpd/details/activation/enabledfromRemoteValuetopotBpdCardsInWalletContainerin order to avoid re-rendering with the same valuesBpdCardsInWalletContainer, from30 secondsto `5 minutes