Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [#176175845] removes transactions list from the transactions screen #2628

Merged
merged 6 commits into from
Jan 22, 2021
Merged

chore: [#176175845] removes transactions list from the transactions screen #2628

merged 6 commits into from
Jan 22, 2021

Conversation

qesya
Copy link
Contributor

@qesya qesya commented Dec 21, 2020

Short description

Removes transactions list from transactions screen and every related parameters
Screenshot 2020-12-21 at 23 22 28

@qesya qesya requested a review from debiff December 21, 2020 22:26
@qesya qesya self-assigned this Dec 21, 2020
@pagopa-github-bot pagopa-github-bot changed the title [#176175845] removes transactions list from the transactions screen chore: [#176175845] removes transactions list from the transactions screen Dec 21, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 21, 2020 •
edited
Loading

Affected stories

  • ⚙️ #176175845: Rimuovere storico operazioni pagoPA da pagine di dettaglio metodo

Generated by 🚫 dangerJS against ba11440

@codecov
Copy link

codecov bot commented Dec 22, 2020 •
edited
Loading

Codecov Report

Merging #2628 (ba11440) into master (ba523c1) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2628      +/-   ##
==========================================
+ Coverage   53.35%   53.36%   +0.01%     
==========================================
  Files         760      760              
  Lines       21238    21216      -22     
  Branches     4027     4027              
==========================================
- Hits        11331    11322       -9     
+ Misses       9854     9841      -13     
  Partials       53       53
Impacted Files Coverage Δ
ts/screens/wallet/TransactionsScreen.tsx 46.66% <50.00%> (+1.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba523c1...ba11440. Read the comment docs.

debiff
debiff suggested changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@debiff debiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you delete the props that are no longer used?

@qesya qesya force-pushed the 176175845-remove-operations-log branch from 35ec6dc to 6df9777 Compare January 21, 2021 18:36
@debiff debiff merged commit ec5437b into master Jan 22, 2021
@debiff debiff deleted the 176175845-remove-operations-log branch January 22, 2021 11:19
@debiff debiff mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debiff debiff debiff approved these changes

@Undermaken Undermaken Undermaken approved these changes

@CrisTofani CrisTofani Awaiting requested review from CrisTofani

@fabriziofff fabriziofff Awaiting requested review from fabriziofff

Assignees

@qesya qesya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qesya @pagopa-github-bot @Undermaken @debiff