Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bonus Pagamenti Digitali): [#176129361] Cashback payment method. Change footer buttons logic #2592

Merged
merged 7 commits into from
Dec 15, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Dec 15, 2020

Short description

This PR reviews the footer buttons logic as follows:

  • continue button is enabled if at least one method is active on BPD
  • skip button is enabled if no method is active on BPD
when cashback is active when cashback activation is just completed
Preferences Privacy

review footer button enabling login
@Undermaken Undermaken changed the title [#176129361] Cashback payment method. New footer button logic [#176129361] Cashback payment method. New footer buttons logic Dec 15, 2020
@pagopa-github-bot pagopa-github-bot changed the title [#176129361] Cashback payment method. New footer buttons logic fix(Bonus Pagamenti Digitali): [#176129361] Cashback payment method. New footer buttons logic Dec 15, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 15, 2020

Affected stories

  • 🐞 #176129361: Il pulsante Continua nella schermata per attivare il Cashback deve essere disabilitato se il toggle non è stato attivato

Generated by 🚫 dangerJS against c74daa2

@Undermaken Undermaken changed the title fix(Bonus Pagamenti Digitali): [#176129361] Cashback payment method. New footer buttons logic fix(Bonus Pagamenti Digitali): [#176129361] Cashback payment method. Change footer buttons logic Dec 15, 2020
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #2592 (c74daa2) into master (cd57293) will increase coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2592      +/-   ##
==========================================
+ Coverage   50.64%   50.65%   +0.01%     
==========================================
  Files         708      709       +1     
  Lines       20221    20247      +26     
  Branches     3580     3904     +324     
==========================================
+ Hits        10241    10257      +16     
- Misses       9936     9946      +10     
  Partials       44       44              
Impacted Files Coverage Δ
.../screens/onboarding/EnrollPaymentMethodsScreen.tsx 55.81% <36.36%> (-7.05%) ⬇️
...creens/bpd/ActivateBpdOnNewPaymentMethodScreen.tsx 73.07% <44.44%> (-11.14%) ⬇️
...bonus/bpd/store/reducers/details/paymentMethods.ts 52.08% <100.00%> (+9.58%) ⬆️
...ures/bonus/bpd/store/reducers/__mock__/bancomat.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd57293...c74daa2. Read the comment docs.

@Undermaken Undermaken marked this pull request as ready for review December 15, 2020 11:19
@Undermaken Undermaken merged commit 187fa70 into master Dec 15, 2020
@Undermaken Undermaken deleted the 176129361-fix-cta-bpd-onboarding-completed branch December 15, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants