-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Bonus Pagamenti Digitali): [#176129361] Cashback payment method. Change footer buttons logic #2592
Merged
Undermaken
merged 7 commits into
master
from
176129361-fix-cta-bpd-onboarding-completed
Dec 15, 2020
Merged
fix(Bonus Pagamenti Digitali): [#176129361] Cashback payment method. Change footer buttons logic #2592
Undermaken
merged 7 commits into
master
from
176129361-fix-cta-bpd-onboarding-completed
Dec 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
review footer button enabling login
Undermaken
changed the title
[#176129361] Cashback payment method. New footer button logic
[#176129361] Cashback payment method. New footer buttons logic
Dec 15, 2020
pagopa-github-bot
changed the title
[#176129361] Cashback payment method. New footer buttons logic
fix(Bonus Pagamenti Digitali): [#176129361] Cashback payment method. New footer buttons logic
Dec 15, 2020
Affected stories
|
Undermaken
changed the title
fix(Bonus Pagamenti Digitali): [#176129361] Cashback payment method. New footer buttons logic
fix(Bonus Pagamenti Digitali): [#176129361] Cashback payment method. Change footer buttons logic
Dec 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #2592 +/- ##
==========================================
+ Coverage 50.64% 50.65% +0.01%
==========================================
Files 708 709 +1
Lines 20221 20247 +26
Branches 3580 3904 +324
==========================================
+ Hits 10241 10257 +16
- Misses 9936 9946 +10
Partials 44 44
Continue to review full report at Codecov.
|
debiff
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR reviews the footer buttons logic as follows:
continue
button is enabled if at least one method is active on BPDskip
button is enabled if no method is active on BPD