Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bonus Pagamenti Digitali): [#176137613] Warning banner shows a wrong icon #2578

Merged
merged 15 commits into from
Dec 14, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Dec 14, 2020

THIS PR depends on #2570

Short description

Icon should be "info"

Schermata 2020-12-14 alle 09 22 49
Schermata 2020-12-14 alle 09 22 57

@pagopa-github-bot pagopa-github-bot changed the title [#176137613] Warning banner shows a wrong icon fix(Bonus Pagamenti Digitali): [#176137613] Warning banner shows a wrong icon Dec 14, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 14, 2020

Affected stories

  • 🐞 #176137613: [trivial] Nei banner di avviso di livello warning l'icon deve essere una "i" e non un "!"

Generated by 🚫 dangerJS against 6c560e7

…of github.com:pagopa/io-app into 176137613-warning-icon
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #2578 (6c560e7) into master (99a9209) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2578    +/-   ##
========================================
  Coverage   50.64%   50.64%            
========================================
  Files         708      708            
  Lines       20157    20157            
  Branches     3560     3880   +320     
========================================
  Hits        10209    10209            
  Misses       9902     9902            
  Partials       46       46            
Impacted Files Coverage Δ
ts/components/SectionStatusComponent.tsx 57.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a9209...6c560e7. Read the comment docs.

@@ -31,6 +31,8 @@ const styles = StyleSheet.create({
alignItems: "flex-start",
alignContent: "center"
},
alignCenter: { alignSelf: "center" },
verticalFlipped: { transform: [{ rotateZ: "180deg" }] },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May we remove this unused style attribute?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed within 6c560e7

@CrisTofani CrisTofani merged commit e407fa0 into master Dec 14, 2020
@CrisTofani CrisTofani deleted the 176137613-warning-icon branch December 14, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants