Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175165668,#175165677] IBAN code is now Monospace Bold and selectable on KO screens #2542

Merged
merged 3 commits into from
Dec 9, 2020

Conversation

DavideValdo
Copy link
Contributor

How to test

  • Comment the switch in MainIbanScreen.tsx line 30, replace with return <IbanKOWrong contextualHelp={emptyContextualHelp} />;, IbanKONotOwned uses the same IbanKoBody component underneath
  • Insert any IBAN code

Changes

  • IBAN should be bold
  • Press on the IBAN code, you should be able to copy it in the clipboard

Schermata 2020-12-09 alle 18 22 20

@pagopa-github-bot pagopa-github-bot changed the title [#175165668,#175165677] IBAN code is now Monospace Bold and selectable on KO screens feat(Bonus Pagamenti Digitali): [#175165668,#175165677] IBAN code is now Monospace Bold and selectable on KO screens Dec 9, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 9, 2020

Affected stories

  • 🌟 #175165668: Come CIT voglio poter copiare l'iban errato dalle schermate di KO
  • 🌟 #175165677: Rendere l'iban Monospace Bold nelle schermate Iban KO

Generated by 🚫 dangerJS against f8c876f

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #2542 (f8c876f) into master (12b0cd5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2542   +/-   ##
=======================================
  Coverage   50.55%   50.55%           
=======================================
  Files         705      705           
  Lines       20033    20033           
  Branches     3868     3866    -2     
=======================================
  Hits        10128    10128           
  Misses       9859     9859           
  Partials       46       46           
Impacted Files Coverage Δ
ts/components/core/typography/Monospace.tsx 100.00% <ø> (ø)
.../features/bonus/bpd/screens/iban/ko/IbanKoBody.tsx 80.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b0cd5...f8c876f. Read the comment docs.

@Undermaken Undermaken merged commit 76e0dbf into master Dec 9, 2020
@Undermaken Undermaken deleted the 175165668-175165677-iban-ko-screen-improvements branch December 9, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants