Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#176053275] BPDDetailScreen #2527

Merged
merged 8 commits into from
Dec 8, 2020

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Dec 8, 2020

Short description

This pr changes the representation of different states for the payment method section.

None Error Some

List of changes proposed in this pull request

  • Changed representation for WalletPaymentMethodBpdList.tsx
  • Hide BpdSummaryComponent.tsx if period === current and numTransaction === 0

How to test

  • Test the BpdDetail screen with different potValues

@pagopa-github-bot pagopa-github-bot changed the title [#176053275] BPDDetailScreen feat(Bonus Pagamenti Digitali): [#176053275] BPDDetailScreen Dec 8, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 8, 2020

Affected stories

Generated by 🚫 dangerJS against 94f4e43

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #2527 (94f4e43) into master (f609a29) will increase coverage by 0.01%.
The diff coverage is 46.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2527      +/-   ##
==========================================
+ Coverage   50.61%   50.63%   +0.01%     
==========================================
  Files         704      704              
  Lines       19944    19960      +16     
  Branches     3519     3524       +5     
==========================================
+ Hits        10095    10106      +11     
- Misses       9803     9808       +5     
  Partials       46       46              
Impacted Files Coverage Δ
...nents/paymentMethod/WalletPaymentMethodBpdList.tsx 55.00% <34.61%> (+0.83%) ⬆️
...details/components/summary/BpdSummaryComponent.tsx 75.86% <100.00%> (+2.78%) ⬆️
...eens/details/components/summary/TextualSummary.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f609a29...94f4e43. Read the comment docs.

@fabriziofff fabriziofff marked this pull request as ready for review December 8, 2020 17:40
@Undermaken Undermaken merged commit e9eb0cb into master Dec 8, 2020
@fabriziofff fabriziofff deleted the 176053275-bpd-detail-screen-rework branch January 21, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants