Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bonus Pagamenti Digitali): [#176007328] Overflow of payment method representation component (used in bpd toggle) #2493

Merged
merged 10 commits into from
Dec 7, 2020

Conversation

fabriziofff
Copy link
Contributor

Short description

This pr fixes the text overflow for PaymentMethodRepresentationComponent

Schermata 2020-12-04 alle 11 39 29

How to test

  • Insert a very long name in PaymentMethodBpdToggle caption parameter

@pagopa-github-bot pagopa-github-bot changed the title [#176007328] Overflow of payment method representation component (used in bpd toggle) fix(Bonus Pagamenti Digitali): [#176007328] Overflow of payment method representation component (used in bpd toggle) Dec 4, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 4, 2020

Affected stories

  • 🐞 #176007328: [minor] overflow del testo nome della banca nel toggle attivazione cashback

Generated by 🚫 dangerJS against 092f3f1

@fabriziofff fabriziofff marked this pull request as draft December 4, 2020 10:42
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #2493 (092f3f1) into master (94fcd68) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2493    +/-   ##
========================================
  Coverage   50.55%   50.55%            
========================================
  Files         700      700            
  Lines       19716    19716            
  Branches     3812     3502   -310     
========================================
  Hits         9967     9967            
  Misses       9703     9703            
  Partials       46       46            
Impacted Files Coverage Δ
...ggle/base/PaymentMethodRepresentationComponent.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94fcd68...092f3f1. Read the comment docs.

@fabriziofff fabriziofff marked this pull request as ready for review December 7, 2020 10:24
@CrisTofani CrisTofani merged commit d4416fd into master Dec 7, 2020
@CrisTofani CrisTofani deleted the 176007328-overflow-pm-representation-component branch December 7, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants