Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175971953] No retries and increased timeout for PM requests #2484

Merged
merged 6 commits into from
Dec 3, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Dec 3, 2020

Short description

This PR changes the fetch configuration for all requests to Payment Manager
Furthermore this PR fixes a double render in WalletHomeScreen

before

  • timeout 10sec
  • retries 0/3 (for some requests 0, 3 for others)

now

  • timeout 16sec
  • retries 0

@pagopa-github-bot pagopa-github-bot changed the title [#175971953] No retries and increased timeout for PM requests feat(Bonus Pagamenti Digitali): [#175971953] No retries and increased timeout for PM requests Dec 3, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 3, 2020

Affected stories

  • 🌟 #175971953: Il client che si interfaccia con le API del PM non deve fare retry e attendere la risposta per 16 secondi

Generated by 🚫 dangerJS against c414941

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #2484 (c414941) into master (12b4333) will decrease coverage by 0.01%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2484      +/-   ##
==========================================
- Coverage   50.57%   50.56%   -0.02%     
==========================================
  Files         700      700              
  Lines       19700    19706       +6     
  Branches     3808     3807       -1     
==========================================
+ Hits         9964     9965       +1     
- Misses       9690     9695       +5     
  Partials       46       46              
Impacted Files Coverage Δ
ts/sagas/wallet.ts 22.99% <ø> (ø)
ts/screens/wallet/WalletHomeScreen.tsx 26.17% <0.00%> (-0.56%) ⬇️
ts/features/bonus/bpd/api/backendBpdClient.ts 45.45% <33.33%> (+0.14%) ⬆️
...odActivationToggle/base/PaymentMethodBpdToggle.tsx 33.33% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b4333...c414941. Read the comment docs.

@Undermaken Undermaken marked this pull request as ready for review December 3, 2020 09:55
@fabriziofff fabriziofff merged commit ffce56d into master Dec 3, 2020
@fabriziofff fabriziofff deleted the 175971953-increase-timeout-0-retry branch December 3, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants