Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bonus Pagamenti Digitali): [#175953061] Fix overflow in transaction item #2477

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

fabriziofff
Copy link
Contributor

Short description

This pr fixes the overflow of the payment method name in the transaction item.

Before After

List of changes proposed in this pull request

  • Rewrited from scratch the BaseBpdTransactionItem.tsx layout.

How to test

  • Add a very long name for props.title and / or props.rightText

@fabriziofff fabriziofff changed the title [#175953061] fix overflow in transaction item [#175953061] Fix overflow in transaction item Dec 2, 2020
@pagopa-github-bot pagopa-github-bot changed the title [#175953061] Fix overflow in transaction item fix(Bonus Pagamenti Digitali): [#175953061] Fix overflow in transaction item Dec 2, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 2, 2020

Affected stories

  • 🐞 #175953061: [minor] Overflow testo in transaction item

Generated by 🚫 dangerJS against b4f457a

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #2477 (b4f457a) into master (08e1e9d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2477    +/-   ##
========================================
  Coverage   50.52%   50.52%            
========================================
  Files         696      696            
  Lines       19584    19585     +1     
  Branches     3491     3802   +311     
========================================
+ Hits         9894     9895     +1     
  Misses       9644     9644            
  Partials       46       46            
Impacted Files Coverage Δ
...tures/bonus/bpd/store/reducers/details/combiner.ts 61.53% <ø> (ø)
...ponents/transactionItem/BaseBpdTransactionItem.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e1e9d...b4f457a. Read the comment docs.

@CrisTofani CrisTofani merged commit 8f19134 into master Dec 2, 2020
@CrisTofani CrisTofani deleted the 175953061-fix-overflow-in-transaction-item branch December 2, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants