Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175884177] Adds BPay/Satispay card component #2438

Merged
merged 8 commits into from
Nov 27, 2020

Conversation

CrisTofani
Copy link
Contributor

Short description

This PR implements a common Card component for Satispay and BancomatPay and it's corresponding wrapper components for specific methods.

On BpayCard in case of missing bank logo, the card will display bank name.

Schermata 2020-11-26 alle 14 50 15

Schermata 2020-11-26 alle 14 50 46

@pagopa-github-bot pagopa-github-bot changed the title [#175884177] Adds BPay/Satispay card component feat(Bonus Pagamenti Digitali): [#175884177] Adds BPay/Satispay card component Nov 26, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 26, 2020

Affected stories

  • 🌟 #175884177: Come DEV voglio avere un componente generico per rappresentare la card di Satispay e BancomatPay

Generated by 🚫 dangerJS against a3a0de3

@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #2438 (a18f445) into master (cb168f1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2438    +/-   ##
========================================
  Coverage   50.07%   50.07%            
========================================
  Files         672      672            
  Lines       19170    19170            
  Branches     3752     3447   -305     
========================================
  Hits         9600     9600            
  Misses       9524     9524            
  Partials       46       46            

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb168f1...a3a0de3. Read the comment docs.

Copy link
Contributor

@fabriziofff fabriziofff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schermata 2020-11-27 alle 10 05 06

Could you add also the phone number for BPay?
We have this information available for BPay in BPayPaymentMethod.info.numberObfuscated

@fabriziofff fabriziofff merged commit ad27dcf into master Nov 27, 2020
@fabriziofff fabriziofff deleted the 175884177-satispay-bpay-card branch November 27, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants