Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175883590] Satispay and Bancomatpay selector #2429

Merged
merged 7 commits into from
Nov 26, 2020

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Nov 25, 2020

Short description

This pr adds the selector fo BPay and BancomatPay.

List of changes proposed in this pull request

  • Added creditCardListSelector, satispayListSelector and bPayListSelector.
  • Moved enhanceBancomat and enhancePaymentMethod to utils.
  • Added fix for changelog scope generation.

How to test

Run ts/store/reducers/wallet/__tests__/wallets.test.ts

@pagopa-github-bot pagopa-github-bot changed the title [#175883590] Satispay and Bancomatpay selector feat: [#175883590] Satispay and Bancomatpay selector Nov 25, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 25, 2020

Affected stories

  • 🌟 #175883590: Come DEV voglio avere dei selector per filtrare i metodi di pagamento di tipo Satispay e BancomatPay

Generated by 🚫 dangerJS against aa25467

@fabriziofff fabriziofff marked this pull request as ready for review November 25, 2020 12:06
@codecov-io
Copy link

codecov-io commented Nov 25, 2020

Codecov Report

Merging #2429 (15fb68e) into master (8268fb2) will increase coverage by 0.10%.
The diff coverage is 91.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2429      +/-   ##
==========================================
+ Coverage   50.03%   50.14%   +0.10%     
==========================================
  Files         671      669       -2     
  Lines       19072    19037      -35     
  Branches     3420     3415       -5     
==========================================
+ Hits         9543     9546       +3     
+ Misses       9483     9445      -38     
  Partials       46       46              
Impacted Files Coverage Δ
ts/types/pagopa.ts 100.00% <ø> (+4.59%) ⬆️
ts/store/reducers/wallet/wallets.ts 51.30% <85.71%> (+4.63%) ⬆️
ts/utils/paymentMethod.ts 79.66% <94.11%> (+24.34%) ⬆️
scripts/changelog/ts/changelog.ts 72.72% <100.00%> (-1.12%) ⬇️
...features/wallet/component/WalletV2PreviewCards.tsx 81.81% <100.00%> (ø)
...et/onboarding/bancomat/store/reducers/addedPans.ts 65.00% <100.00%> (ø)
...archBancomat/SearchAvailableUserBancomatScreen.tsx 51.61% <0.00%> (-2.68%) ⬇️
ts/boot/configureInstabug.ts 46.80% <0.00%> (-2.09%) ⬇️
ts/sagas/wallet.ts 22.22% <0.00%> (-0.73%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e51f3a...aa25467. Read the comment docs.

@pagopa-github-bot pagopa-github-bot changed the title feat: [#175883590] Satispay and Bancomatpay selector feat(Bonus Pagamenti Digitali): [#175883590] Satispay and Bancomatpay selector Nov 25, 2020
@pagopa-github-bot pagopa-github-bot changed the title feat(Bonus Pagamenti Digitali): [#175883590] Satispay and Bancomatpay selector feat: [#175883590] Satispay and Bancomatpay selector Nov 25, 2020
@pagopa-github-bot pagopa-github-bot changed the title feat: [#175883590] Satispay and Bancomatpay selector feat(Bonus Pagamenti Digitali): [#175883590] Satispay and Bancomatpay selector Nov 25, 2020
@Undermaken Undermaken merged commit 1e22fb0 into master Nov 26, 2020
@Undermaken Undermaken deleted the 175883590-satispay-bancomatpay-selector branch November 26, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants