Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bonus Pagamenti Digitali): [#175717757,#175876304] Empty footer cuts screen content on BPD Detail #2423

Merged
merged 4 commits into from
Nov 26, 2020

Conversation

CrisTofani
Copy link
Contributor

Short description

This PR fixes the cut content by footer on BPD detail screen.

Before After
image image

This PR includes some minor fixes on transactions list items and header for content padding.

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 24, 2020

Affected stories

  • 🐞 #175717757: [trivial] Nel dettaglio cashback, quando manca la CTA ancorata in basso, il contenuto della pagina viene "tagliato" male
  • 🐞 #175876304: [trivial] L'header sticky è più piccolo del item traguardo e quando questo finisce sotto crea un difetto grafico

Generated by 🚫 dangerJS against 8721bf8

@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #2423 (bbb5155) into master (f15930d) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2423      +/-   ##
==========================================
- Coverage   50.05%   50.04%   -0.01%     
==========================================
  Files         669      669              
  Lines       19027    19021       -6     
  Branches     3415     3415              
==========================================
- Hits         9524     9520       -4     
+ Misses       9457     9455       -2     
  Partials       46       46              
Impacted Files Coverage Δ
...onus/bpd/components/BaseDailyTransactionHeader.tsx 100.00% <ø> (ø)
...ponents/transactionItem/BaseBpdTransactionItem.tsx 100.00% <ø> (ø)
...eens/details/transaction/BpdTransactionsScreen.tsx 37.17% <0.00%> (ø)
...res/bonus/bpd/screens/details/BpdDetailsScreen.tsx 52.00% <29.41%> (-11.64%) ⬇️
...d/screens/details/transaction/GoToTransactions.tsx 100.00% <100.00%> (+46.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f15930d...7628a86. Read the comment docs.

@CrisTofani CrisTofani changed the title 175717757 footer cuts detail [#175717757] Empty footer cuts screen content on BPD Detail Nov 24, 2020
@CrisTofani CrisTofani changed the title [#175717757] Empty footer cuts screen content on BPD Detail [#175717757,#175876304] Empty footer cuts screen content on BPD Detail Nov 24, 2020
@pagopa-github-bot pagopa-github-bot changed the title [#175717757,#175876304] Empty footer cuts screen content on BPD Detail fix(Bonus Pagamenti Digitali): [#175717757,#175876304] Empty footer cuts screen content on BPD Detail Nov 24, 2020
@fabriziofff fabriziofff merged commit 09ed3f6 into master Nov 26, 2020
@fabriziofff fabriziofff deleted the 175717757-footer-cuts-detail branch November 26, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants