Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175718879] Show remote faqs #2419

Merged
merged 6 commits into from
Nov 24, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Nov 24, 2020

Short description

This PR is based on this one pagopa/io-services-metadata#154
Now the faqs showed in the Contextual Help could be remote or local.
Remote ones, if defined, will be always displayed in place of local

how to test

  • get the last commit from io-dev-api-server branch support-bpd
  • io-dev-api-server yarn generate:all
  • app yarn generate:all

@pagopa-github-bot pagopa-github-bot changed the title [#175718879] Show remote faqs feat(Bonus Pagamenti Digitali): [#175718879] Show remote faqs Nov 24, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 24, 2020

Affected stories

  • 🌟 #175718879: Come DEV voglio gestire gli help in modalità remota

Generated by 🚫 dangerJS against cc4a755

@Undermaken Undermaken marked this pull request as ready for review November 24, 2020 11:34
@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #2419 (0ec2eeb) into master (023ff1b) will decrease coverage by 0.01%.
The diff coverage is 13.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2419      +/-   ##
==========================================
- Coverage   50.35%   50.33%   -0.02%     
==========================================
  Files         666      666              
  Lines       18845    18850       +5     
  Branches     3378     3680     +302     
==========================================
  Hits         9489     9489              
- Misses       9306     9311       +5     
  Partials       50       50              
Impacted Files Coverage Δ
ts/components/FAQComponent.tsx 80.00% <0.00%> (-3.34%) ⬇️
ts/components/ContextualHelpModal.tsx 37.50% <14.28%> (-2.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023ff1b...0ec2eeb. Read the comment docs.

@fabriziofff fabriziofff merged commit 5bf8066 into master Nov 24, 2020
@fabriziofff fabriziofff deleted the 175718879-remote-faq branch November 24, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants