feat(Bonus Pagamenti Digitali): [#175579023] FeaturedCards carousel in wallet home screen #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
Affected stories
|
Undermaken
suggested changes
Nov 18, 2020
| const FeaturedCard: React.FunctionComponent<Props> = (props: Props) => ( | ||
| <TouchableDefaultOpacity style={styles.container} onPress={props.onPress}> | ||
| <View style={styles.row}> | ||
| {fromNullable(props.image).fold( |
There was a problem hiding this comment.
Suggested change
| {fromNullable(props.image).fold( | |
| {maybeNotNullyString(props.image).fold( |
This could be safer: it checks that string is not null and empty. We could have some troubles when props are {image:""}
| /> | ||
| ); | ||
| case ID_BPD_TYPE: | ||
| return getValue(props.bpdActiveBonus) ? null : ( |
There was a problem hiding this comment.
Suggested change
| return getValue(props.bpdActiveBonus) ? null : ( | |
| return getValue(props.bpdActiveBonus) === false && ( |
Maybe this could be a refactoring
Codecov Report
@@ Coverage Diff @@
## master #2398 +/- ##
========================================
Coverage 50.08% 50.09%
========================================
Files 656 658 +2
Lines 18499 18580 +81
Branches 3611 3334 -277
========================================
+ Hits 9265 9307 +42
- Misses 9186 9225 +39
Partials 48 48
Continue to review full report at Codecov.
|
Undermaken
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR implements the featured cards carousel on wallet home screen.