Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [#175420010] Added in Circle CI a job to test if the CIE button exists #2375

Merged
merged 8 commits into from
Nov 17, 2020

Conversation

GiovanniMancini
Copy link
Contributor

Short description

CIE authentication is started by pressing a button on an appropriate page (See CIE AUTH DOC), which in turn runs the JS function apriIosUL. In order to automate the task without user intervention, the App uses a webview component and JS injection to run the apriIosUL function even though the button hasn't been pressed. That pull requests adds a CI job to test if the button exists.

List of changes proposed in this pull request

  • Added new job in CircleCI yml file
  • Added new python program to do the check
  • Added related unit tests

How to test

I have included a minimal set of unit tests and checked the success case (the button does exist) running as follows the job with circleci local cli

circleci local execute --job io_check_cie_button_exists_ios

@pagopa-github-bot pagopa-github-bot changed the title [#175420010] Added in Circle CI a job to test if the CIE button exists chore: [#175420010] Added in Circle CI a job to test if the CIE button exists Nov 12, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 12, 2020

Affected stories

  • ⚙️ #175420010: Aggiungere in CI un controllo quotidiano: il pulsante "apri CieID" sia presente nell'autenticazione iOS

Generated by 🚫 dangerJS against d5b3581

@codecov-io
Copy link

codecov-io commented Nov 12, 2020

Codecov Report

Merging #2375 (0dc5c8a) into master (25a3001) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2375   +/-   ##
=======================================
  Coverage   49.25%   49.25%           
=======================================
  Files         636      636           
  Lines       17867    17867           
  Branches     3234     3234           
=======================================
  Hits         8800     8800           
  Misses       9024     9024           
  Partials       43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a3001...6e69b22. Read the comment docs.

@Undermaken Undermaken merged commit a3dd9d3 into master Nov 17, 2020
@Undermaken Undermaken deleted the 175420010-ci-existence-cie-ios-button-daily branch November 17, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants