-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [#175420010] Added in Circle CI a job to test if the CIE button exists #2375
Merged
Undermaken
merged 8 commits into
master
from
175420010-ci-existence-cie-ios-button-daily
Nov 17, 2020
Merged
chore: [#175420010] Added in Circle CI a job to test if the CIE button exists #2375
Undermaken
merged 8 commits into
master
from
175420010-ci-existence-cie-ios-button-daily
Nov 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…python script as a job named io_check_cie_button_exists_ios
GiovanniMancini
requested review from
CrisTofani,
fabriziofff,
francescopersico and
Undermaken
as code owners
November 12, 2020 16:15
pagopa-github-bot
changed the title
[#175420010] Added in Circle CI a job to test if the CIE button exists
chore: [#175420010] Added in Circle CI a job to test if the CIE button exists
Nov 12, 2020
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2375 +/- ##
=======================================
Coverage 49.25% 49.25%
=======================================
Files 636 636
Lines 17867 17867
Branches 3234 3234
=======================================
Hits 8800 8800
Misses 9024 9024
Partials 43 43 Continue to review full report at Codecov.
|
Undermaken
suggested changes
Nov 12, 2020
…ut) is at least 5 secs
…y' of https://github.com/pagopa/io-app into 175420010-ci-existence-cie-ios-button-daily
Undermaken
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
CIE authentication is started by pressing a button on an appropriate page (See CIE AUTH DOC), which in turn runs the JS function
apriIosUL
. In order to automate the task without user intervention, the App uses awebview
component and JS injection to run theapriIosUL
function even though the button hasn't been pressed. That pull requests adds a CI job to test if the button exists.List of changes proposed in this pull request
How to test
I have included a minimal set of unit tests and checked the success case (the button does exist) running as follows the job with
circleci
localcli
circleci local execute --job io_check_cie_button_exists_ios