Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175663318] Handle pans response with messages #2370

Merged
merged 5 commits into from
Nov 12, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Nov 11, 2020

Short description

This PR adds the handling of messages inside /pans response payload

Now pans app model contains

  • pans
  • messages

how to test

  • make sure you have the last commit of io-dev-server on branch support-bpd

@pagopa-github-bot pagopa-github-bot changed the title [#175663318] Handle pans response with messages feat(Bonus Pagamenti Digitali): [#175663318] Handle pans response with messages Nov 11, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 11, 2020

Affected stories

  • 🌟 #175663318: Il DEV server e l'app deve supportare la API /pans secondo le nuove specifiche

Generated by 🚫 dangerJS against 3c5269d

@codecov-io
Copy link

codecov-io commented Nov 11, 2020

Codecov Report

Merging #2370 (ce3a75d) into master (4c54678) will decrease coverage by 0.00%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2370      +/-   ##
==========================================
- Coverage   49.23%   49.22%   -0.01%     
==========================================
  Files         635      635              
  Lines       17827    17830       +3     
  Branches     3518     3518              
==========================================
  Hits         8777     8777              
- Misses       9007     9010       +3     
  Partials       43       43              
Impacted Files Coverage Δ
...allet/onboarding/bancomat/saga/networking/index.ts 24.13% <0.00%> (-0.87%) ⬇️
...ng/bancomat/screens/add-pans/AddBancomatScreen.tsx 34.04% <0.00%> (-1.52%) ⬇️
...archBancomat/SearchAvailableUserBancomatScreen.tsx 57.14% <0.00%> (ø)
.../wallet/onboarding/bancomat/store/actions/index.ts 100.00% <ø> (ø)
.../wallet/onboarding/bancomat/store/reducers/pans.ts 60.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c54678...ce3a75d. Read the comment docs.

@Undermaken Undermaken marked this pull request as ready for review November 11, 2020 18:54
@fabriziofff fabriziofff merged commit ac80ca3 into master Nov 12, 2020
@fabriziofff fabriziofff deleted the 175663318-sync-pans-api branch November 12, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants