feat(Bonus Pagamenti Digitali): [#175265955] Bpd payment method refinement #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…179-transaction-details
…668-unsubscribe-bpd
…on-details' into 175266668-unsubscribe-bpd
…nItem.tsx Co-authored-by: Matteo Boschi <[email protected]>
…ansactionDetailComponent.tsx Co-authored-by: Matteo Boschi <[email protected]>
…ansactionDetailComponent.tsx Co-authored-by: Matteo Boschi <[email protected]>
…on-details' into 175266668-unsubscribe-bpd
…668-unsubscribe-bpd
fabriziofff
requested review from
CrisTofani,
francescopersico and
Undermaken
as code owners
…be-bpd' into 175488300-iban-cr-rework
…pd-payment-method-refinement
…75269179-transaction-details
…om:pagopa/io-app into 175266668-unsubscribe-bpd
…be-bpd' into 175488300-iban-cr-rework
…pd-payment-method-refinement
…75266668-unsubscribe-bpd
…agopa/io-app into 175488300-iban-cr-rework
…300-iban-cr-rework
…pd-payment-method-refinement
…955-bpd-payment-method-refinement
…75488300-iban-cr-rework
…gopa/io-app into 175265955-bpd-payment-method-refinement
Undermaken
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr depends on #2360
Short description
This pr finalizes the graphical representation of payment methods in the bpd details.
wallet.length === 0bpd is not activated on any methodnotActivable methods (no capability or activated by someone elseoverview with FAKE data, the not activable will have the (!)
List of changes proposed in this pull request
PaymentMethodGroupedListin order to render the payment method toggle grouped by activable, not activable, activate on other channel.PaymentMethodList.tsxtoPaymentMethodRawList.tsx.WalletPaymentMethodBpdListin order to display the required warnings.atLeastOnePaymentMethodHasBpdEnabledSelectorto know if there is at least one active payment method.walletV2WithActivationStatusSelectorin order to provide ready data toPaymentMethodGroupedListHow to test
Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.