feat(Bonus Pagamenti Digitali): [#175488300,#175662744] Iban insertion and workflow (rework due to change request) #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…179-transaction-details
…668-unsubscribe-bpd
…on-details' into 175266668-unsubscribe-bpd
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2360 +/- ##
==========================================
- Coverage 49.26% 49.23% -0.04%
==========================================
Files 636 635 -1
Lines 17832 17829 -3
Branches 3511 3229 -282
==========================================
- Hits 8785 8778 -7
- Misses 9004 9008 +4
Partials 43 43
Continue to review full report at Codecov.
|
fabriziofff
changed the title
…nItem.tsx Co-authored-by: Matteo Boschi <[email protected]>
…ansactionDetailComponent.tsx Co-authored-by: Matteo Boschi <[email protected]>
…ansactionDetailComponent.tsx Co-authored-by: Matteo Boschi <[email protected]>
…on-details' into 175266668-unsubscribe-bpd
fabriziofff
requested review from
CrisTofani,
francescopersico and
Undermaken
as code owners
…668-unsubscribe-bpd
…be-bpd' into 175488300-iban-cr-rework
…75269179-transaction-details
…om:pagopa/io-app into 175266668-unsubscribe-bpd
…be-bpd' into 175488300-iban-cr-rework
…75266668-unsubscribe-bpd
…agopa/io-app into 175488300-iban-cr-rework
Undermaken
suggested changes
Nov 11, 2020
| @@ -32,13 +33,17 @@ const IbanKoBody: React.FunctionComponent<Props> = props => { | |||
| "", | |||
| iban => iban as string | |||
| ); | |||
| const style = fromNullable(props.isFlex).getOrElse(true) ? IOStyles.flex : {}; | |||
There was a problem hiding this comment.
Suggested change
| const style = fromNullable(props.isFlex).getOrElse(true) ? IOStyles.flex : {}; | |
| const style = props.isFlex ?? true ? IOStyles.flex : {}; |
fabriziofff
commented
Nov 11, 2020
ts/features/bonus/bpd/store/reducers/details/activation/index.ts
Outdated
Show resolved
Hide resolved
Undermaken
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr depends on #2355
Short description
This pr changes the Iban insertion workflow in order to accept a change request and api modification.
IbanKoNotOwnedList of changes proposed in this pull request
case IbanStatus.OK: and case IbanStatus.CANT_VERIFY:: now allows the user to continue in the workflow (before was onlycase IbanStatus.OK:.bpdIbanPrefillSelectorin order to calculate the "prefill" value for the IBAN input textfield (should be upsertvalue if !== undefined, else payoffInstr value if present, else "").IbanKOCannotVerify.tsxscreen, not accessible but kept in case of second thoughts.IbanKONotOwned.tsxto accept the design changes.