feat(Bonus Pagamenti Digitali): [#175266668] Unsubscribe from bpd #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…179-transaction-details
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2355 +/- ##
========================================
Coverage 48.91% 48.92%
========================================
Files 633 634 +1
Lines 17767 17829 +62
Branches 3210 3505 +295
========================================
+ Hits 8691 8722 +31
- Misses 9034 9065 +31
Partials 42 42
Continue to review full report at Codecov.
|
…668-unsubscribe-bpd
fabriziofff
requested review from
CrisTofani,
francescopersico and
Undermaken
as code owners
…on-details' into 175266668-unsubscribe-bpd
…nItem.tsx Co-authored-by: Matteo Boschi <[email protected]>
…ansactionDetailComponent.tsx Co-authored-by: Matteo Boschi <[email protected]>
…ansactionDetailComponent.tsx Co-authored-by: Matteo Boschi <[email protected]>
…on-details' into 175266668-unsubscribe-bpd
…668-unsubscribe-bpd
…75269179-transaction-details
…om:pagopa/io-app into 175266668-unsubscribe-bpd
Undermaken
approved these changes
Nov 11, 2020
ts/features/bonus/bonusVacanze/components/buttons/ButtonConfigurations.ts
Outdated
Show resolved
Hide resolved
ts/features/bonus/bpd/store/reducers/details/activation/index.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr depends on #2354
Short description
This pr adds the complete unsubscription experience for the user.
Compared to the version displayed, the opacity has been increased and the cancel cashback button has been standardized to the design
List of changes proposed in this pull request
BottomSheetContent.tsxto handle a footer (temp solution).BpdDetailsScreen.tsxin order to handle the loading, error, success ofunsubscriptionUnsubscribeComponent.tsxas bottomsheet content.UnsubscribeToBpd.tsxin order to handle the bottomsheet / unsubscription confirm.unsubscription: RemoteValue<true, Error>;to the store in order to know the outcome of the unsubscription.bottomSheetRawConfigto configure a bottomsheet with raw content (needed to add a footer).