Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175269179] Transaction details #2354

Merged
merged 12 commits into from
Nov 10, 2020

Conversation

fabriziofff
Copy link
Contributor

Short description

This pr adds the bottomsheet with details for a transaction.

Normal MaxTransactionCashback
MaxPeriodCashback CancelTransaction

List of changes proposed in this pull request

  • Added keyId: string; maxCashbackForTransactionAmount: number | undefined; to EnhancedBpdTransaction.
  • Added BpdTransactionDetailComponent to render a transaction detail.
  • Added

How to test

Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

@pagopa-github-bot pagopa-github-bot changed the title [#175269179] Transaction details feat(Bonus Pagamenti Digitali): [#175269179] Transaction details Nov 9, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 9, 2020

Affected stories

  • 🌟 #175269179: Come CIT voglio visualizzare il dettaglio di una singola transazione

Generated by 🚫 dangerJS against 274d418

@codecov-io
Copy link

codecov-io commented Nov 9, 2020

Codecov Report

Merging #2354 (be95d86) into master (afc463b) will increase coverage by 0.05%.
The diff coverage is 66.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2354      +/-   ##
==========================================
+ Coverage   48.85%   48.90%   +0.05%     
==========================================
  Files         631      633       +2     
  Lines       17722    17772      +50     
  Branches     3492     3495       +3     
==========================================
+ Hits         8658     8692      +34     
- Misses       9022     9038      +16     
  Partials       42       42              
Impacted Files Coverage Δ
ts/components/core/typography/Monospace.tsx 100.00% <ø> (ø)
ts/components/core/variables/IOStyles.ts 100.00% <ø> (ø)
...features/bonus/bpd/saga/networking/transactions.ts 50.00% <ø> (ø)
...s/features/bonus/bpd/store/actions/transactions.ts 100.00% <ø> (ø)
...tails/transaction/detail/BpdTransactionWarning.tsx 46.15% <46.15%> (ø)
.../components/transactionItem/BpdTransactionItem.tsx 66.66% <50.00%> (-33.34%) ⬇️
...tures/bonus/bpd/store/reducers/details/combiner.ts 40.27% <50.00%> (+1.14%) ⬆️
...eens/details/transaction/BpdTransactionsScreen.tsx 88.88% <60.00%> (+5.55%) ⬆️
...ansaction/detail/BpdTransactionDetailComponent.tsx 83.33% <83.33%> (ø)
ts/components/bottomSheet/BottomSheetHeader.tsx 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc463b...01914c4. Read the comment docs.

@Undermaken Undermaken merged commit 7d867d9 into master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants