-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Bonus Pagamenti Digitali): [#175269179] Transaction details #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziofff
requested review from
CrisTofani,
francescopersico and
Undermaken
as code owners
November 9, 2020 19:38
pagopa-github-bot
changed the title
[#175269179] Transaction details
feat(Bonus Pagamenti Digitali): [#175269179] Transaction details
Nov 9, 2020
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2354 +/- ##
==========================================
+ Coverage 48.85% 48.90% +0.05%
==========================================
Files 631 633 +2
Lines 17722 17772 +50
Branches 3492 3495 +3
==========================================
+ Hits 8658 8692 +34
- Misses 9022 9038 +16
Partials 42 42
Continue to review full report at Codecov.
|
Undermaken
suggested changes
Nov 10, 2020
ts/features/bonus/bpd/components/transactionItem/BpdTransactionItem.tsx
Outdated
Show resolved
Hide resolved
ts/features/bonus/bpd/screens/details/transaction/detail/BpdTransactionDetailComponent.tsx
Outdated
Show resolved
Hide resolved
ts/features/bonus/bpd/screens/details/transaction/detail/BpdTransactionDetailComponent.tsx
Outdated
Show resolved
Hide resolved
ts/features/bonus/bpd/screens/details/transaction/detail/BpdTransactionWarning.tsx
Outdated
Show resolved
Hide resolved
…nItem.tsx Co-authored-by: Matteo Boschi <[email protected]>
…ansactionDetailComponent.tsx Co-authored-by: Matteo Boschi <[email protected]>
…ansactionDetailComponent.tsx Co-authored-by: Matteo Boschi <[email protected]>
Undermaken
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pr adds the bottomsheet with details for a transaction.
List of changes proposed in this pull request
keyId: string; maxCashbackForTransactionAmount: number | undefined;
toEnhancedBpdTransaction
.BpdTransactionDetailComponent
to render a transaction detail.How to test
Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.