feat(Bonus Pagamenti Digitali): [#175263506] Create BPD card component #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
requested review from
fabriziofff,
francescopersico and
Undermaken
as code owners
CrisTofani
changed the title
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2338 +/- ##
==========================================
- Coverage 48.68% 48.36% -0.32%
==========================================
Files 615 604 -11
Lines 17276 17045 -231
Branches 3111 3088 -23
==========================================
- Hits 8410 8244 -166
+ Misses 8824 8759 -65
Partials 42 42
Continue to review full report at Codecov.
|
…506-bpd-card-component
fabriziofff
suggested changes
Nov 4, 2020
| }); | ||
|
|
||
| type BadgeDefinition = { | ||
| style: any; |
There was a problem hiding this comment.
Suggested change
| style: any; | |
| style: StyleProp<ViewStyle>; |
There was a problem hiding this comment.
I wanted to change it before opening the PR, but then missed it at the end. Thanks!
Comment on lines
+184
to
+190
| <Badge style={[formatStatusBadge().style, styles.badgeBase]}> | ||
| <Text | ||
| semibold={true} | ||
| style={styles.badgeTextBase} | ||
| dark={props.period.status !== "Closed"} | ||
| > | ||
| {formatStatusBadge().label} |
There was a problem hiding this comment.
In order to avoid multiple execution of the function formatStatusBadge maybe we can use const badgeFormat = formatStatusBadge() in BpdCardComponent and use badgeFormat.style and badgeFormat.label.
What you think?
There was a problem hiding this comment.
absolutely! sounds good
fabriziofff
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the base component for BPD card detail
Full card
Preview card