Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175263900] Add winning transaction API #2333

Merged
merged 8 commits into from
Nov 3, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Nov 2, 2020

Short description

This PR does some refactoring about spec naming and it adds the support for winning transactions API

how to test

  • app: yarn generate:all
  • io-dev-server: make sure you have the last commit from support-bpd branch then yarn generate:all; yarn start

support BPD winning transactions API
@pagopa-github-bot pagopa-github-bot changed the title [#175263900] Add winning transaction API feat(Bonus Pagamenti Digitali): [#175263900] Add winning transaction API Nov 2, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 2, 2020

Affected stories

  • 🌟 #175263900: Come DEV voglio richiedere la lista delle transazioni effettuate da un cittadino in uno specifico periodo di cashback

Generated by 🚫 dangerJS against 9e1c1b5

@Undermaken Undermaken marked this pull request as ready for review November 2, 2020 14:24
@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #2333 into master will decrease coverage by 0.00%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2333      +/-   ##
==========================================
- Coverage   48.32%   48.32%   -0.01%     
==========================================
  Files         604      604              
  Lines       17048    17064      +16     
  Branches     3378     3378              
==========================================
+ Hits         8239     8246       +7     
- Misses       8767     8776       +9     
  Partials       42       42              
Impacted Files Coverage Δ
ts/features/bonus/bpd/saga/index.ts 60.52% <0.00%> (ø)
ts/features/bonus/bpd/saga/networking/amount.ts 60.00% <ø> (ø)
...s/features/bonus/bpd/store/actions/transactions.ts 100.00% <ø> (ø)
ts/features/bonus/bpd/api/backendBpdClient.ts 43.28% <40.00%> (-0.27%) ⬇️
...features/bonus/bpd/saga/networking/transactions.ts 50.00% <46.66%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b8e0b...bcddef3. Read the comment docs.

@fabriziofff fabriziofff merged commit 4c3bbae into master Nov 3, 2020
@fabriziofff fabriziofff deleted the 175263900-bpd-period-transactions branch November 3, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants