-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Bonus Pagamenti Digitali): [#175515542,#175266771] Add entrypoint for draft Transactions screen #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…374-bpd-details-organization
…374-bpd-details-organization
…741-iban-component
pagopa-github-bot
changed the title
[#175515542] Transactions screen stub
feat(Bonus Pagamenti Digitali): [#175515542] Transactions screen stub
Oct 30, 2020
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2330 +/- ##
==========================================
+ Coverage 48.61% 48.62% +0.01%
==========================================
Files 613 616 +3
Lines 17239 17310 +71
Branches 3394 3117 -277
==========================================
+ Hits 8380 8417 +37
- Misses 8817 8851 +34
Partials 42 42
Continue to review full report at Codecov.
|
fabriziofff
changed the title
feat(Bonus Pagamenti Digitali): [#175515542] Transactions screen stub
feat(Bonus Pagamenti Digitali): [#175515542,#175266771] Transactions screen stub
Oct 30, 2020
fabriziofff
changed the title
feat(Bonus Pagamenti Digitali): [#175515542,#175266771] Transactions screen stub
feat(Bonus Pagamenti Digitali): [#175515542,#175266771] Add entrypoint for draft Transactions screen
Oct 30, 2020
fabriziofff
requested review from
CrisTofani,
francescopersico and
Undermaken
as code owners
October 30, 2020 18:54
…onent' into 174848741-iban-component
…on-screen-stub' into 175515542-transaction-screen-stub
…74848741-iban-component
…ransaction-screen-stub
…75266374-bpd-details-organization
…hub.com:pagopa/io-app into 174848741-iban-component
…74848741-iban-component
…gopa/io-app into 175515542-transaction-screen-stub
Undermaken
suggested changes
Nov 4, 2020
Co-authored-by: Matteo Boschi <[email protected]>
…on-screen-stub' into 175515542-transaction-screen-stub
Undermaken
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr depends on #2328
Short description
This pr adds the stub for the
BpdTransactionsScreen
and the entrypoint to navigate to this screen inBpdDetailsScreen
.The button to access to the transactions list is visible only if for the selected period there is at least one transaction [will be never visible in a future (inactive) period].
List of changes proposed in this pull request
BpdTransactionsScreen
.BpdTransactionsScreen
.GoToTransactions
asBpdDetailsScreen
footer. All the visualization business logic is contained withinGoToTransactions
.useLoadPotValue
that allows to try to load and retry to load a pot if is in error state.