Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175515542,#175266771] Add entrypoint for draft Transactions screen #2330

Merged
merged 51 commits into from
Nov 4, 2020

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Oct 30, 2020

This pr depends on #2328

Short description

This pr adds the stub for the BpdTransactionsScreen and the entrypoint to navigate to this screen in BpdDetailsScreen.
The button to access to the transactions list is visible only if for the selected period there is at least one transaction [will be never visible in a future (inactive) period].

List of changes proposed in this pull request

  • Added routes & navigation actions for BpdTransactionsScreen.
  • Added draft BpdTransactionsScreen.
  • Added GoToTransactions as BpdDetailsScreen footer. All the visualization business logic is contained within GoToTransactions.
  • Added a generic hook useLoadPotValue that allows to try to load and retry to load a pot if is in error state.

@pagopa-github-bot pagopa-github-bot changed the title [#175515542] Transactions screen stub feat(Bonus Pagamenti Digitali): [#175515542] Transactions screen stub Oct 30, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 30, 2020

Affected stories

  • 🌟 #175515542: Come DEV voglio avere degli stub che definiscono l'organizzazione della schermata della lista transazioni
  • 🌟 #175266771: Come CIT voglio accedere alla lista delle transazioni a partire dalla schermata di dettaglio bpd

Generated by 🚫 dangerJS against bed6138

@codecov-io
Copy link

codecov-io commented Oct 30, 2020

Codecov Report

Merging #2330 into master will increase coverage by 0.01%.
The diff coverage is 51.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2330      +/-   ##
==========================================
+ Coverage   48.61%   48.62%   +0.01%     
==========================================
  Files         613      616       +3     
  Lines       17239    17310      +71     
  Branches     3394     3117     -277     
==========================================
+ Hits         8380     8417      +37     
- Misses       8817     8851      +34     
  Partials       42       42              
Impacted Files Coverage Δ
...odActivationToggle/base/PaymentMethodBpdToggle.tsx 35.08% <ø> (ø)
ts/features/bonus/bpd/navigation/routes.ts 100.00% <ø> (ø)
...s/bonus/bpd/store/reducers/details/transactions.ts 60.00% <0.00%> (ø)
ts/utils/hooks/useLoadPotValue.ts 17.85% <17.85%> (ø)
...d/screens/details/transaction/GoToTransactions.tsx 60.71% <60.71%> (ø)
ts/features/bonus/bpd/navigation/actions.ts 100.00% <100.00%> (ø)
ts/features/bonus/bpd/navigation/navigator.ts 100.00% <100.00%> (ø)
...res/bonus/bpd/screens/details/BpdDetailsScreen.tsx 100.00% <100.00%> (ø)
...eens/details/transaction/BpdTransactionsScreen.tsx 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c2cfb...bed6138. Read the comment docs.

@fabriziofff fabriziofff changed the title feat(Bonus Pagamenti Digitali): [#175515542] Transactions screen stub feat(Bonus Pagamenti Digitali): [#175515542,#175266771] Transactions screen stub Oct 30, 2020
@fabriziofff fabriziofff changed the title feat(Bonus Pagamenti Digitali): [#175515542,#175266771] Transactions screen stub feat(Bonus Pagamenti Digitali): [#175515542,#175266771] Add entrypoint for draft Transactions screen Oct 30, 2020
@fabriziofff fabriziofff marked this pull request as ready for review October 30, 2020 18:54
@Undermaken Undermaken merged commit e79f77e into master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants