Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#174575010] Add showroom listitem #2317

Merged
merged 6 commits into from
Oct 27, 2020

Conversation

debiff
Copy link
Contributor

@debiff debiff commented Oct 26, 2020

Short description

This PR add the line item which allows you to reach the showroom screen.

List of changes proposed in this pull request

  • Added the showroom list item to the profileMainScreen
  • Added the header to the Showroom component

@pagopa-github-bot pagopa-github-bot changed the title [#174575010] Add showroom listitem feat: [#174575010] Add showroom listitem Oct 26, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 26, 2020

Affected stories

  • 🌟 #174575010: Aggiungere un item nella sezione sviluppatori che rimanda allo showroom

Generated by 🚫 dangerJS against 24b53b0

@codecov-io
Copy link

Codecov Report

Merging #2317 into master will increase coverage by 0.19%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2317      +/-   ##
==========================================
+ Coverage   47.86%   48.06%   +0.19%     
==========================================
  Files         582      588       +6     
  Lines       16781    16857      +76     
  Branches     3339     3342       +3     
==========================================
+ Hits         8033     8102      +69     
- Misses       8706     8713       +7     
  Partials       42       42              
Impacted Files Coverage Δ
ts/navigation/MainNavigator.tsx 42.37% <ø> (ø)
ts/navigation/routes.ts 100.00% <ø> (ø)
ts/screens/profile/ProfileMainScreen.tsx 27.70% <0.00%> (-0.19%) ⬇️
ts/navigation/ProfileNavigator.ts 100.00% <100.00%> (ø)
ts/screens/showroom/Showroom.tsx 76.47% <100.00%> (ø)
ts/screens/showroom/core/SelectionShowroom.tsx 100.00% <0.00%> (ø)
ts/screens/showroom/OthersShowroom.tsx 100.00% <0.00%> (ø)
ts/screens/showroom/ShowroomSection.tsx 100.00% <0.00%> (ø)
ts/screens/showroom/core/ColorsShowroom.tsx 90.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f6a70...24b53b0. Read the comment docs.

@fabriziofff fabriziofff merged commit 72c0200 into master Oct 27, 2020
@fabriziofff fabriziofff deleted the 174575010-add-showroom-section branch October 27, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants