Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Bonus Pagamenti Digitali): [#175419552] Enhance add bancomat response #2315

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

Undermaken
Copy link
Contributor

Short description

Instead of take the first element in the wallet list response, check if the added wallet is present in it (a wallet with the same hpan)

@pagopa-github-bot pagopa-github-bot changed the title [#175419552] Enhance add bancomat response chore(Bonus Pagamenti Digitali): [#175419552] Enhance add bancomat response Oct 23, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 23, 2020

Affected stories

  • ⚙️ #175419552: Migliorare il check per verificare che il bancomat sia stato effettivamente aggiunto

Generated by 🚫 dangerJS against 0ebe016

@codecov-io
Copy link

codecov-io commented Oct 27, 2020

Codecov Report

Merging #2315 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2315      +/-   ##
==========================================
- Coverage   48.06%   48.05%   -0.01%     
==========================================
  Files         588      588              
  Lines       16857    16857              
  Branches     3065     3342     +277     
==========================================
- Hits         8102     8101       -1     
- Misses       8713     8714       +1     
  Partials       42       42              
Impacted Files Coverage Δ
...allet/onboarding/bancomat/saga/networking/index.ts 26.92% <0.00%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c0200...0ebe016. Read the comment docs.

@fabriziofff fabriziofff merged commit 1705c39 into master Oct 27, 2020
@fabriziofff fabriziofff deleted the 175419552-enhance-add-bancomat-response branch January 21, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants