Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175011989,#175012026,#175012064] Style for onboarding bancomat KO and loading screens #2276

Merged
merged 34 commits into from
Oct 9, 2020

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Oct 9, 2020

This pr depends on #2273

Short description

This pr update the styles and text for BancomatKoNotFound, BancomatKoTimeout and LoadBancomatSearch.

BancomatKoNotFound BancomatKoTimeout LoadBancomatSearch

@pagopa-github-bot pagopa-github-bot changed the title [#175011989,#175012026,#175012064] Style for onboarding bancomat KO and loading screens feat(Bonus Pagamenti Digitali): [#175011989,#175012026,#175012064] Style for onboarding bancomat KO and loading screens Oct 9, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 9, 2020

Affected stories

  • 🌟 #175011989: Creazione schermata di loading lista bancomat
  • 🌟 #175012026: Creazione schermata KO non siamo riusciti a contattare la tua banca
  • 🌟 #175012064: Creazione schermata KO non sono stati trovati bancomat

Generated by 🚫 dangerJS against e857c13

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@c6a0f5f). Click here to learn what that means.
The diff coverage is 70.41%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2276   +/-   ##
=========================================
  Coverage          ?   48.03%           
=========================================
  Files             ?      557           
  Lines             ?    16067           
  Branches          ?     2935           
=========================================
  Hits              ?     7718           
  Misses            ?     8307           
  Partials          ?       42           
Impacted Files Coverage Δ
...allet/onboarding/bancomat/saga/networking/index.ts 33.33% <14.28%> (ø)
ts/components/wallet/PaymentMethodsList.tsx 46.00% <50.00%> (ø)
ts/sagas/workUnit/index.ts 50.00% <50.00%> (ø)
...omat/screens/searchBancomat/LoadBancomatSearch.tsx 55.00% <55.00%> (ø)
...archBancomat/SearchAvailableUserBancomatScreen.tsx 57.14% <57.14%> (ø)
ts/screens/wallet/AddPaymentMethodScreen.tsx 51.42% <57.14%> (ø)
.../onboarding/bancomat/store/reducers/abiSelected.ts 60.00% <60.00%> (ø)
.../wallet/onboarding/bancomat/store/reducers/pans.ts 60.00% <60.00%> (ø)
...bancomat/saga/orchestration/addBancomatToWallet.ts 63.63% <63.63%> (ø)
...nboarding/bancomat/screens/TMPSearchBankScreen.tsx 75.00% <75.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a0f5f...f87c139. Read the comment docs.

@fabriziofff fabriziofff marked this pull request as ready for review October 9, 2020 10:44
@Undermaken Undermaken merged commit bed6ab5 into master Oct 9, 2020
@fabriziofff fabriziofff deleted the 175012026-ko-and-loading-screens branch January 21, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants