Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175165785] Remove api-key from BPD requests #2272

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

Undermaken
Copy link
Contributor

Short description

  • remove Ocp-Apim-Subscription-Key header from BPD requests
  • remove BPD_API_KEY key/value from .env files

how to test

  • specs are been update yarn generate:all

remove api key header
@pagopa-github-bot pagopa-github-bot changed the title [#175165785] Remove api-key from BPD requests feat(Bonus Pagamenti Digitali): [#175165785] Remove api-key from BPD requests Oct 8, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 8, 2020

Affected stories

  • 🌟 #175165785: Rimuovere l'header Ocp-Apim-Subscription-Key dalle richieste verso le API BPD

Generated by 🚫 dangerJS against 6679d49

@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

Merging #2272 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
- Coverage   47.86%   47.85%   -0.01%     
==========================================
  Files         541      541              
  Lines       15738    15736       -2     
  Branches     3151     3151              
==========================================
- Hits         7533     7531       -2     
  Misses       8163     8163              
  Partials       42       42              
Impacted Files Coverage Δ
ts/config.ts 100.00% <ø> (ø)
ts/features/bonus/bpd/api/backendBpdClient.ts 36.36% <ø> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fda0ec...6679d49. Read the comment docs.

@Undermaken Undermaken marked this pull request as ready for review October 8, 2020 08:10
@fabriziofff fabriziofff merged commit a7219ac into master Oct 8, 2020
@fabriziofff fabriziofff deleted the 175165785-revert-bpd-test-authorization-token branch October 8, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants