feat(Bonus Pagamenti Digitali): [#175011093,#175011182] Add bancomat entrypoint and stub navigation #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mat-entrypoint-and-stub-navigation
pagopa-github-bot
changed the title
Affected stories
|
…mat-entrypoint-and-stub-navigation
Codecov Report
@@ Coverage Diff @@
## master #2269 +/- ##
==========================================
- Coverage 47.92% 47.86% -0.06%
==========================================
Files 543 554 +11
Lines 15788 16031 +243
Branches 3159 3200 +41
==========================================
+ Hits 7566 7674 +108
- Misses 8180 8315 +135
Partials 42 42
Continue to review full report at Codecov.
|
fabriziofff
requested review from
CrisTofani,
francescopersico and
Undermaken
as code owners
fabriziofff
changed the title
fabriziofff
changed the title
Undermaken
suggested changes
Oct 7, 2020
| * the navigation stack return to the screen from which the saga was invoked | ||
| * @param g | ||
| */ | ||
| export function* withResetNavigationStack<T>( |
There was a problem hiding this comment.
Could it be an enhancement?
In this way we can call withResetNavigationStack by passing also the parameters taken by g
export function* withResetNavigationStack<T>(
g: (...args: any) => Generator<Effect, T>,
args?: Array<any>
): Generator<Effect, T, any> {
const currentNavigationStackSize: ReturnType<typeof navigationHistorySizeSelector> = yield select(
navigationHistorySizeSelector
);
const res: T = yield call(() => (args ? g(...args) : g()));
const newNavigationStackSize: ReturnType<typeof navigationHistorySizeSelector> = yield select(
navigationHistorySizeSelector
);
const deltaNavigation = newNavigationStackSize - currentNavigationStackSize;
if (deltaNavigation > 1) {
yield put(navigationHistoryPop(deltaNavigation - 1));
}
yield put(NavigationActions.back());
return res;
}There was a problem hiding this comment.
My idea, in case of a saga with some parameters was to use:
const res: SagaCallReturnType<typeof executeWorkUnit> = yield call(
withResetNavigationStack,
() => bancomatWorkUnit("Hola, ¿que tal?")
);In order to preserve the type of the arguments of the g method. Using args?: Array<any> I could pass any types and any size of parameters which may not match the signature.
What you think?
…mat-entrypoint-and-stub-navigation
Undermaken
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pr adds an entry point for the
add bancomat as payment methodand a base template to orchestrate single unit of work.List of changes proposed in this pull request
PaymentMethodsList.tsxin order to acceptspaymentMethods?: ReadonlyArray<IPaymentMethod>;AddPaymentMethodScreen.tsxin order to add theadd bancomatentry point (only whenbpdEnabledand!inPayment.isSome()).WorkUnitto model the information needed to execute a single work unit.withResetNavigationStackutility saga to execute another saga and restore the navigation stack after the execution.executeWorkUnit, a saga used to execute a single work unit.navigationHistorySizeSelectorto read from the store the size of the navigation stack.bancomatWorkUnitto execute theadd bancomat to walletwork unit.addBancomatToWalletGenericto concat the operation ofadd bancomat to walletand goto wallethomescreen (placeholder, will be refined in the next iterations).