Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#175058139] Remove subtitle change pin screen #2268

Merged
merged 3 commits into from
Oct 7, 2020

Conversation

debiff
Copy link
Contributor

@debiff debiff commented Oct 7, 2020

Short description

This PR remove the subtitle from the subtitle from the change pin screen since the message is no longer true.

List of changes proposed in this pull request

Removed the subtitle from the component and the labels from the language files.

@pagopa-github-bot pagopa-github-bot changed the title [#175058139] Remove subtitle change pin screen feat: [#175058139] Remove subtitle change pin screen Oct 7, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 7, 2020

Affected stories

  • 🌟 #175058139: rimuovere il subtitle dall'item "cambia codice di sblocco"

Generated by 🚫 dangerJS against a682185

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #2268 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2268      +/-   ##
==========================================
- Coverage   47.83%   47.83%   -0.01%     
==========================================
  Files         541      539       -2     
  Lines       15720    15640      -80     
  Branches     3150     3138      -12     
==========================================
- Hits         7520     7481      -39     
+ Misses       8158     8118      -40     
+ Partials       42       41       -1     
Impacted Files Coverage Δ
ts/screens/profile/ProfileMainScreen.tsx 27.81% <ø> (ø)
ts/navigation/MainNavigator.tsx 41.37% <0.00%> (ø)
...s/bonus/bpd/screens/iban/ko/IbanKOCannotVerify.tsx
...tures/bonus/bpd/screens/iban/ko/IbanKONotOwned.tsx
.../screens/iban/insertion/IbanInsertionComponent.tsx
.../features/bonus/bpd/screens/iban/ko/IbanKoBody.tsx
...bpd/screens/iban/insertion/IbanInsertionScreen.tsx
...features/bonus/bpd/screens/iban/ko/IbanKOWrong.tsx
...features/bonus/bpd/screens/iban/IbanKONotOwned.tsx 87.50% <0.00%> (ø)
ts/features/bonus/bpd/screens/iban/IbanKOWrong.tsx 81.25% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf9337...a682185. Read the comment docs.

@Undermaken Undermaken merged commit 312eeef into master Oct 7, 2020
@Undermaken Undermaken deleted the 175058139-remove-subtitle-change-pin branch October 7, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants